This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Paste from Office support for Safari #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reinmar
reviewed
Oct 26, 2018
| import multipleStylesSingleLineModel from './multiple-styles-single-line/model.word2016.html'; | ||
| import multipleStylesMultilineModel from './multiple-styles-multiline/model.word2016.html'; | ||
|
|
||
| export const fixtures = { |
There was a problem hiding this comment.
I don't really understand what's in fixtures and browserFixtures and how it is used later on. I see they are combined somehow... Could you perhaps add a README.md to tests/ explaining what's the process of adding more tests using this system?
There was a problem hiding this comment.
I have added README.md file describing briefly each part of testing mechanism and some short step-by-step guide on adding new tests 👍
Mgsy
approved these changes
Nov 5, 2018
Reinmar
reviewed
Nov 5, 2018
tests/README.md
Outdated
| @@ -0,0 +1,221 @@ | |||
| # Normalization and integration testing in `Paste from Office` | |||
There was a problem hiding this comment.
Suggested change
| # Normalization and integration testing in `Paste from Office` | |
| # Testing this package |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other: Support for pasting flat list and spacing handling for pasted content in Safari. Closes ckeditor/ckeditor5#2481. Closes ckeditor/ckeditor5#2480. Closes ckeditor/ckeditor5#2511.
Additional information
Bringing support for Safari required few things:
In the context of pasted content it was adapting function for recognizing Word content and handling some spacing issues.
The bigger change was in the way how tests are run. As Safari produces different input when content is pasted (different than Chrome, Firefox and Edge), the mechanism for switching fixtures depending on a browser was needed. Eventually, we have decided that all fixtures can be tested in each browser (thus simplifying the code by skipping browser detection and eliminating the need to run tests on all browsers after a change).
To satisfy the above, the special util was created which is used to generate tests based on provided fixtures (and this basically closes tickets related to testing infrastructure ckeditor/ckeditor5#2481 and ckeditor/ckeditor5#2480).
Note: As this PR was built on top of
t/8, it can be merged only after #11 (t/8PR) is merged.