Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Initial implementation #1

Merged
merged 12 commits into from
Sep 30, 2019
Merged

Initial implementation #1

merged 12 commits into from
Sep 30, 2019

Conversation

pomek
Copy link
Member

@pomek pomek commented Sep 12, 2019

Suggested merge commit message (convention)

Feature: Initial implementation. Closes ckeditor/ckeditor5#1194.


Additional information

We need to improve the demo but it can be done outside this PR.

@Reinmar Reinmar self-assigned this Sep 17, 2019
@pomek
Copy link
Member Author

pomek commented Sep 19, 2019

I improved the demo snippet. I added a button that opens a print preview window after clicking:

image

For the above content, it will show something like on the picture below:

image

@pomek
Copy link
Member Author

pomek commented Sep 19, 2019

@dkonopka, could you check whether the pageBreak widget is being rendered correctly with float images?

@dkonopka
Copy link

WFM 👍

@mlewand mlewand self-requested a review September 25, 2019 08:47
Copy link
Contributor

@mlewand mlewand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks fine.

I don't know why data is downcasted the way it is thoug, see the review comments for more details.

@MSGY I'd like to ask you to give it a quick testing. It is very similar to the horizontal rule (line) feature, but I'd still love to have another pair of eyes to check it.

@pomek Please make a 0.0.1 pre-release so that CI already kicks in.

src/pagebreakediting.js Show resolved Hide resolved
src/pagebreakui.js Outdated Show resolved Hide resolved
docs/_snippets/features/page-break.html Outdated Show resolved Hide resolved
@mlewand mlewand self-requested a review September 30, 2019 10:12
Copy link
Contributor

@mlewand mlewand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine now.

While doing 47135ef you didn't adjust the TC in https://github.com/ckeditor/ckeditor5-page-break/blob/a8b6d7b/tests/pagebreakui.js#L47 which caused tests to fail. I'll fix that as a part of R.

I also added a reference to your comment explaining putting span inside a div.

@mlewand mlewand merged commit f5849d5 into master Sep 30, 2019
@pomek pomek deleted the t/ckeditor5/1194 branch September 30, 2019 13:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the possibility to insert page breaks
5 participants