Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented use of official CKEditor5 typings #137

Merged
merged 3 commits into from
Mar 9, 2023
Merged

Implemented use of official CKEditor5 typings #137

merged 3 commits into from
Mar 9, 2023

Conversation

przemyslaw-zan
Copy link
Member

@przemyslaw-zan przemyslaw-zan commented Feb 28, 2023

Suggested merge commit message (convention)

Feature: Replaced the community typings with the official CKEditor 5. Closes #110.

Other: The ckeditor5 package is no longer a dependency of a created package. Instead, it is marked as a peer dependency to enable using the newly created package with the latest CKEditor 5 versions.


Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

Supported scopes

@pomek
Copy link
Member

pomek commented Mar 6, 2023

Spelling errors in the title and the proposed merge message.

pomek added 2 commits March 8, 2023 13:41
…lling the generated package with the newest CKEditor 5 versions.
Copy link
Member

@pomek pomek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pomek pomek merged commit f2f8264 into master Mar 9, 2023
@pomek pomek deleted the i/110 branch March 9, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use CKEditor 5 typings
2 participants