Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The generated README.md still references old "dll:build" commands. #174

Closed
tfujii opened this issue Jul 16, 2024 · 0 comments · Fixed by #179
Closed

The generated README.md still references old "dll:build" commands. #174

tfujii opened this issue Jul 16, 2024 · 0 comments · Fixed by #179
Assignees
Labels
type:bug This issue reports a buggy (incorrect) behavior.
Milestone

Comments

@tfujii
Copy link

tfujii commented Jul 16, 2024

📝 Provide detailed reproduction steps (if any)

  1. Create a new package.
  2. Read the generated README.md.

✔️ Expected result

The new README.md file should reference the new npm commands such as "build:dist".

❌ Actual result

The new README.md file describes the usage of the removed "dll:build" commands, and points to legacy documentation for CKEditor.

❓ Possible solution

Please update the generator template for the README.md.

📃 Other details

  • Node: v20.15.1
  • Npm / Yarn: 10.5.2
  • First affected version: 2.0.0

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@tfujii tfujii added the type:bug This issue reports a buggy (incorrect) behavior. label Jul 16, 2024
@pszczesniak pszczesniak self-assigned this Jul 17, 2024
pszczesniak added a commit that referenced this issue Jul 24, 2024
…kage

Fix (generator): Each package template should have own `README.md` based on what commands can be execute in it. Closes #174.
@CKEditorBot CKEditorBot added this to the iteration 76 milestone Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
3 participants