Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed to dll:build when using optional chaining(?) ( Terser error) #136

Closed
geril2207 opened this issue Feb 21, 2023 · 0 comments · Fixed by #148
Closed

Failed to dll:build when using optional chaining(?) ( Terser error) #136

geril2207 opened this issue Feb 21, 2023 · 0 comments · Fixed by #148
Assignees
@martnpaneq
Labels
squad:platform Issue to be handled by the Platform team. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 63

Comments

@geril2207
Copy link

📝 Provide detailed reproduction steps (if any)

  1. …Generate test package
  2. …Use optional chaining somewhere(someObj?.name)
  3. …Build the package ( yarn prepare || yarn dll:build)

✔️ Expected result

Success build

❌ Actual result

ERROR in plugin.js from Terser
Unexpected token: punc (.) [plugin.js:558,37]

❓ Possible solution

Its a problem with Terser maybe should update deps.

📃 Other details

  • Node: 16.13.1
  • Npm / Yarn: 1.22.17
  • First affected version: …

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@geril2207 geril2207 added the type:bug This issue reports a buggy (incorrect) behavior. label Feb 21, 2023
@pomek pomek added the squad:platform Issue to be handled by the Platform team. label Apr 7, 2023
@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Apr 12, 2023
@martnpaneq martnpaneq self-assigned this Apr 19, 2023
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Apr 19, 2023
@martnpaneq martnpaneq mentioned this issue Apr 19, 2023
Merged
pomek added a commit that referenced this issue Apr 20, 2023
@pomek
Merge pull request #148 from ckeditor/i/136
fddaa52 
Other (tools): Update `terser-webpack-plugin` to enable optional chaining syntax. Closes #136.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Apr 20, 2023
@CKEditorBot CKEditorBot added this to the iteration 63 milestone Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martnpaneq martnpaneq

Labels
squad:platform Issue to be handled by the Platform team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 63
5 participants
@pomek @CKEditorBot @geril2207 @przemyslaw-zan @martnpaneq