Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Display media-embed label hint immediately #70

Merged
merged 5 commits into from
Jan 4, 2019
Merged

Display media-embed label hint immediately #70

merged 5 commits into from
Jan 4, 2019

Conversation

dkonopka
Copy link
Contributor

@dkonopka dkonopka commented Dec 20, 2018

Suggested merge commit message (convention)

Other: The help text under the media URL input should be displayed when it's empty. The quick insertion tip should pop out when the user started typing in the input (see ckeditor/ckeditor5#2728).

@dkonopka dkonopka requested a review from oleq December 20, 2018 09:42
@coveralls
Copy link

coveralls commented Dec 20, 2018

Pull Request Test Coverage Report for Build 288

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 280: 0.0%
Covered Lines: 304
Relevant Lines: 304

💛 - Coveralls

@oleq
Copy link
Member

oleq commented Dec 20, 2018

TBH it's not exactly what #5 is about. It's more about users not understanding that the input is the place they should paste the media URL rather than displaying a "quick–paste hint", which is a different story.

I was thinking more about "Paste the media URL here" under the input (when it's empty), then "Paste the URL..." when it's not empty.

@dkonopka
Copy link
Contributor Author

dkonopka commented Jan 2, 2019

I guess this PR won't fix #5 actually because it will only improve UX of input instead of adding balloon to the media-embed.

we may need a balloon attached to the media in the future because of media styles (similar to image styles)

Anyway your proposal of:

I was thinking more about "Paste the media URL here" under the input (when it's empty), then "Paste the URL..." when it's not empty.

is better idea instead of current solution, I'll fix it.

@oleq
Copy link
Member

oleq commented Jan 3, 2019

Improved the UX

kapture 2019-01-03 at 15 30 17

Copy link
Member

@oleq oleq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I improved the UX by displaying the help or tip text under the input. Please review the change @dkonopka.

@oleq oleq requested review from oleq and removed request for oleq January 3, 2019 14:33
@dkonopka
Copy link
Contributor Author

dkonopka commented Jan 4, 2019

"Tip part" is a really good idea 👍

@dkonopka dkonopka merged commit 55396b5 into master Jan 4, 2019
@dkonopka dkonopka deleted the t/5 branch January 4, 2019 10:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants