Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to improve the media embed UI? #2728

Closed
oleq opened this issue Aug 20, 2018 · 11 comments
Closed

How to improve the media embed UI? #2728

oleq opened this issue Aug 20, 2018 · 11 comments
Labels
package:media-embed resolution:expired This issue was closed due to lack of feedback. status:discussion status:stale type:question This issue asks a question (how to...).

Comments

@oleq
Copy link
Member

oleq commented Aug 20, 2018

ATM the insertion/editing is via the "dropform" attached to the toolbar button

image

It's been simple to implent and works for MVP but:

  • it makes no sense with the balloon toolbar (editor), which requires a non-collapsed selection to show up and the media embedding should definitely be available for collapsed selections,
  • sometimes it's visually far from the media in the content and it makes editing inconvenient,
    • should we allow media editing anyway?

Some options:

  • if we decided to attach a form with the URL editing field to straight to the media in the content, we'd have to insert a blank (empty, URL–less) media first and then edit its URL, which is an implementation hassle,
    • also what if the user decides they dont want it any more after they pressed the toolbar button? How to treat it in the model/collaboration? Should it be gone as soon as they blur the media? Or maybe removed manually?
  • the insertion similar to the Link feature makes no sense because the media is not inserted at the selection (just like the link) where the balloon's arrow is pointing; it's inserted as a next block, so this would be visually inaccurate

Down the road:

  • still... we may need a balloon attached to the media in the future because of media styles (similar to image styles)
    image
  • the auto embedding could help us out because it's a faster path for the user to do things and with that implemented, we could keep the UI very simple

cc @dkonopka

@pjasiun
Copy link

pjasiun commented Aug 21, 2018

it makes no sense with the balloon toolbar (editor), which requires a non-collapsed selection to show up and the media embedding should definitely be available for collapsed selections,

I believe the issue with inserting content in the balloon editor is not limited to the media embedding. There is the same issue if you want to insert table there. I believe we need a generic solution for it. One solution is the block toolbar, but since not everybody wants to have it, or have not enough space for it, we need to have an alternative solution.

@Reinmar
Copy link
Member

Reinmar commented Aug 21, 2018

Agree with @pjasiun. This is not something to be discussed for media embed only.

still... we may need a balloon attached to the media in the future because of media styles (similar to image styles)

Yup, that's one thing that I find a bit missing now – that something shows up when I click the media widget. That could contain "edit the URL" option if we'll see that it's needed. But I wouldn't base the insertion UI on this.

@scofalik
Copy link
Contributor

After playing with the demo, I'd expect to have a toolbar attached to the media embed placeholder after it is selected. This is the only suggestion I have. I think that it works fine right now, I am just missing that one thing.

I believe the issue with inserting content in the balloon editor is not limited to the media embedding.

Also agree. We all know the limitations of balloon toolbar.

@Reinmar
Copy link
Member

Reinmar commented Aug 27, 2018

I can add one thing – when playing with the demos I felt that something should appear when I focus the widget. But since wasn't happening on a single click, I was often doubleclicking it. So, I too have a strong feeling that something should appear.

@pjasiun
Copy link

pjasiun commented Aug 27, 2018

I also expect that block widget has some action when I click on it. I think that is also could be some generic solution. I can imagine media embed feature where you can edit the URL when you click on the widget and code block feature where can edit the code when you click on the widget. Both working without any dialog. On the other hand, you use a balloon panel to editor image properties (like "alt"). If some widgets will be edited "inline" and some using balloon panels we may end up with two inconsistent UX for widgets which could support both. I think, that we need to establish some rules how block widgets should be edited in the whole editor.

BTW: even though I think that we need a generic UX for block widgets editing, I do not think we should provide a generic code to support it. We could start from media-embed-specific code and when we find out that more widgets share the same code to support a similar UX, we can make it more generic.

@oleq
Copy link
Member Author

oleq commented Dec 17, 2018

I recently got a F2F feedback that the current UI could be confusing, i.e. the user does not know what to do.

image

  • We could display "Paste the media URL here" instead of "http://example.com" to make it clearer.
  • We could immediately display some additional hint that helps users understand what they should do. We already have one but in a different context:

image

cc @dkonopka

@dkonopka
Copy link
Contributor

IMHO displaying hint immediately (even without changing current content) will improve discoverability of this feature sufficiently. 👍

@oleq
Copy link
Member Author

oleq commented Dec 18, 2018

@dkonopka Can you provide a PoC?

dkonopka referenced this issue in ckeditor/ckeditor5-media-embed Jan 4, 2019
Other: The help text under the media URL input should be displayed when it's empty. The quick insertion tip should pop out when the user started typing in the input (see #5).
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-media-embed Oct 9, 2019
@mlewand mlewand added this to the unknown milestone Oct 9, 2019
@mlewand mlewand added status:discussion type:question This issue asks a question (how to...). package:media-embed labels Oct 9, 2019
@Pipehill
Copy link

A balloon above embedded media, similar to images, would be very appreciated. The option of setting a title/text alternative to embedded media is important from a universal design point of view.

@oleq oleq changed the title How to improve the UI? How to improve the media embed UI? Jan 29, 2020
@pomek pomek removed this from the unknown milestone Feb 21, 2022
@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

@CKEditorBot CKEditorBot added the resolution:expired This issue was closed due to lack of feedback. label Nov 3, 2023
@CKEditorBot CKEditorBot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:media-embed resolution:expired This issue was closed due to lack of feedback. status:discussion status:stale type:question This issue asks a question (how to...).
Projects
None yet
Development

No branches or pull requests

9 participants