-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to improve the media embed UI? #2728
Comments
I believe the issue with inserting content in the balloon editor is not limited to the media embedding. There is the same issue if you want to insert table there. I believe we need a generic solution for it. One solution is the block toolbar, but since not everybody wants to have it, or have not enough space for it, we need to have an alternative solution. |
Agree with @pjasiun. This is not something to be discussed for media embed only.
Yup, that's one thing that I find a bit missing now – that something shows up when I click the media widget. That could contain "edit the URL" option if we'll see that it's needed. But I wouldn't base the insertion UI on this. |
After playing with the demo, I'd expect to have a toolbar attached to the media embed placeholder after it is selected. This is the only suggestion I have. I think that it works fine right now, I am just missing that one thing.
Also agree. We all know the limitations of balloon toolbar. |
I can add one thing – when playing with the demos I felt that something should appear when I focus the widget. But since wasn't happening on a single click, I was often doubleclicking it. So, I too have a strong feeling that something should appear. |
I also expect that block widget has some action when I click on it. I think that is also could be some generic solution. I can imagine media embed feature where you can edit the URL when you click on the widget and code block feature where can edit the code when you click on the widget. Both working without any dialog. On the other hand, you use a balloon panel to editor image properties (like "alt"). If some widgets will be edited "inline" and some using balloon panels we may end up with two inconsistent UX for widgets which could support both. I think, that we need to establish some rules how block widgets should be edited in the whole editor. BTW: even though I think that we need a generic UX for block widgets editing, I do not think we should provide a generic code to support it. We could start from media-embed-specific code and when we find out that more widgets share the same code to support a similar UX, we can make it more generic. |
I recently got a F2F feedback that the current UI could be confusing, i.e. the user does not know what to do.
cc @dkonopka |
IMHO displaying hint immediately (even without changing current content) will improve discoverability of this feature sufficiently. 👍 |
@dkonopka Can you provide a PoC? |
Other: The help text under the media URL input should be displayed when it's empty. The quick insertion tip should pop out when the user started typing in the input (see #5).
A balloon above embedded media, similar to images, would be very appreciated. The option of setting a title/text alternative to embedded media is important from a universal design point of view. |
There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue. |
We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it). |
ATM the insertion/editing is via the "dropform" attached to the toolbar button
It's been simple to implent and works for MVP but:
Some options:
Down the road:
cc @dkonopka
The text was updated successfully, but these errors were encountered: