Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

t/145: The URL input should span the width of the balloon #151

Merged
merged 1 commit into from
Sep 8, 2017
Merged

t/145: The URL input should span the width of the balloon #151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions theme/components/linkform.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,11 @@
outline: none;
}

.ck-input-text {
// https://github.com/ckeditor/ckeditor5-link/issues/145
width: 100%;
}

.ck-label {
margin-bottom: ck-spacing( 'tiny' );
}
Expand All @@ -24,12 +29,17 @@
.ck-button {
float: right;

// "Save" and "Cancel" buttons.
& + .ck-button {
margin-right: ck-spacing( 'medium' );
}

// The "Unlink" button.
&:last-child {
float: left;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should replace floats by a flex-box and remove overflow: hidden prom the parent element, but this is not the point of this PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flex-box is only partially supported in IE11, that's why we don't use it in the UI.


& + .ck-button {
float: left;
}
// https://github.com/ckeditor/ckeditor5-link/issues/145
margin-right: 4 * ck-spacing( 'medium' );
}
}
}
Expand Down