This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Allows keeping values for font-size/family when pasting #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eeping fonts that are not defined in the plugins configuration.
…e kept as units instead of preset names.
|
@Reinmar, what should we do if a user used this new option in the |
|
A few tests fail, trying to fix that. |
Reinmar
reviewed
Mar 10, 2020
Reinmar
reviewed
Mar 10, 2020
src/fontfamily/fontfamilyediting.js
Outdated
| @@ -49,7 +49,8 @@ export default class FontFamilyEditing extends Plugin { | |||
| 'Times New Roman, Times, serif', | |||
| 'Trebuchet MS, Helvetica, sans-serif', | |||
| 'Verdana, Geneva, sans-serif' | |||
| ] | |||
| ], | |||
| disableValueMatching: false | |||
Reinmar
reviewed
Mar 10, 2020
| editor.conversion.for( 'downcast' ).attributeToElement( { | ||
| model: FONT_FAMILY, | ||
| view: ( attributeValue, writer ) => { | ||
| return writer.createAttributeElement( 'span', { style: 'font-family:' + attributeValue }, { priority: 7 } ); |
There was a problem hiding this comment.
OK, it was needed to correctly sort the font color and font family and font size styles so they render in a visually correct way. But we need a test for that. Most likely, such a test exist for the previous converter, so it's a matter of copying it.
Reinmar
reviewed
Mar 10, 2020
Reinmar
reviewed
Mar 10, 2020
Reinmar
reviewed
Mar 10, 2020
Reinmar
reviewed
Mar 11, 2020
docs/features/font.md
Outdated
| @@ -47,6 +47,25 @@ ClassicEditor | |||
|
|
|||
| {@snippet features/custom-font-family-options} | |||
|
|
|||
| ### Prevent removing non-specified values | |||
|
|
|||
| By default, all not specified values of `font-family` are removing during the conversion. You can disable this behaviour using `disableValueMatching` option. | |||
There was a problem hiding this comment.
Suggested change
| By default, all not specified values of `font-family` are removing during the conversion. You can disable this behaviour using `disableValueMatching` option. | |
| By default, all not specified values of `font-family` are removing during the conversion. You can disable this behaviour using `disableValueMatching` option. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature: Introduced an option for both (
FontSizeandFontFamily) plugins that allow keeping font-family and font-size values when pasting a text. Closes ckeditor/ckeditor5#6165. Closes ckeditor/ckeditor5#2278.Additional information
TODO: Enable the features in "Paste from ..." demos.