-
Notifications
You must be signed in to change notification settings - Fork 8
Add support for preserving text attributes on enter #63
Conversation
388565f
to
e30f45b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comments to the code. I'll check the behavior in the meantime as well.
Is it possible to set this same behavior to the heading plugin? I mean, copy the element class. |
That's a separate piece (subfeature). Here we're copying text attributes. Copying element attributes would be a separate ticket. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small updates to the tests, docs and one API usage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All is good now. You only missed the selection.getAttributeKeys()
use instead of custom keys retrieval from selection.getAttributes()
.
Yeah, I missed this method somehow 🤦♂. |
Suggested merge commit message (convention)
Feature: Add support for respecting
copyOnEnter
attribute's parameter. Closes ckeditor/ckeditor5#4562.Additional information
Dependent PR:
Mark alignment attribute with 'copyOnEnter' property ckeditor5-alignment#41