-
Notifications
You must be signed in to change notification settings - Fork 40
Introduced Model#createOperationFromJSON #1815
Conversation
… for `OperationFactory#fromJSON`.
This change was already tested and accepted by Cloud Services team. |
What do you think I might not like in using operation factory here? Is there some other option? |
OMG, I realised that it should be |
Fixed in c102fc3. I fixed the same thing in the merge message before but I didn't notice the same mistake in the docs. Static methods need to be referenced ad |
I used I wanted to go with |
Another option would be to move the whole functionallity to the |
Suggested merge commit message (convention)
Feature: Introduced
Model#createOperationFromJSON
which is an alias forOperationFactory#fromJSON
. Closes ckeditor/ckeditor5#6094.Additional information
I actually used
OperationFactory
insideModel#createOperationFromJSON
-- less hassle and more backward compatible. If you don't like this solution, I can removeOperationFactory
and fix related places (I think it was used in three places in our codebase).