This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Nodes are removed from their old parent when they are appended to new parent #1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed to new parent.
|
Needed to fix a test in typing ckeditor/ckeditor5-typing#121 |
Reinmar
added a commit
to ckeditor/ckeditor5-typing
that referenced
this pull request
Sep 12, 2017
Tests: Test fix connected with changes in the engine (ckeditor/ckeditor5-engine#1141).
Reinmar
reviewed
Sep 13, 2017
src/dev-utils/view.js
Outdated
| @@ -852,7 +852,7 @@ function _convertViewElements( rootNode ) { | |||
| const convertedElement = rootNode.is( 'documentFragment' ) ? new ViewDocumentFragment() : _convertElement( rootNode ); | |||
|
|
|||
| // Convert all child nodes. | |||
| for ( const child of rootNode.getChildren() ) { | |||
| for ( const child of [ ...rootNode.getChildren() ] ) { | |||
There was a problem hiding this comment.
Why so serious?
// Convert to array because it is correct to do so. :)
Reinmar
reviewed
Sep 13, 2017
| @@ -235,6 +235,11 @@ export default class DocumentFragment { | |||
| nodes = normalize( nodes ); | |||
|
|
|||
| for ( const node of nodes ) { | |||
| // If node that is being added to this element is already inside another element, first remove it from the old parent. | |||
| if ( node.parent !== null ) { | |||
There was a problem hiding this comment.
I'm hesitating whether I'd rather like if ( node.parent ) or !== null ;| Dunno
There was a problem hiding this comment.
!== null is easier to find when searching codebase
|
What's up with this PR? |
|
W8ing for me having time to check it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix:
viewandmodelnodes will now be removed from their old parent when they are added to a new parent to prevent having same node on multiple elements' children lists. Closes ckeditor/ckeditor5#4182.BREAKING CHANGE: If you will append
viewormodelnode that already has a parent, that node will be first removed from it's parent. This is important if you iterate through element's children and they are moved during that iteration. In that case it's safest to cache the element's children in an array.