This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
T/1031: Ignore mutations which lead to no changes #1039
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix: Mutation observer will ignore children mutations if as a result of several native mutations the element's children haven't changed. Closes ckeditor/ckeditor5#4121.
Additional information
In
ckeditor5-engine/src/view/renderer.js
Lines 508 to 525 in 4a4a89a
Also, I've been thinking that perhaps both functions should end up in the
DomConverter
's public interface one day. But not just yet.