This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
T/1012: Handles with a paragraph when the entire content was removed #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 18, 2017 13:25
Reinmar
reviewed
Jul 18, 2017
tests/model/schema/schema.js
Outdated
| @@ -49,6 +49,10 @@ describe( 'Schema', () => { | |||
| expect( schema.limits ).to.be.instanceOf( Set ); | |||
| } ); | |||
|
|
|||
| it( 'should have defined the limits elements', () => { | |||
There was a problem hiding this comment.
"should mark $root as a limit element"
Reinmar
reviewed
Jul 18, 2017
tests/controller/deletecontent.js
Outdated
| @@ -233,12 +233,6 @@ describe( 'DataController', () => { | |||
| '<heading1>f[]</heading1><paragraph>x</paragraph>' | |||
| ); | |||
|
|
|||
| test( | |||
There was a problem hiding this comment.
It's better to avoid deleting tests completely. This may be the only test which checks if the middle paragraph (foo) is deleted. So, either just adjust its result or add some content outside to not make it a full content selection (and adjust the title).
There was a problem hiding this comment.
PS. Note that you haven't added this test in the "should leave a paragraph if the entire content was selected" block.
Reinmar
reviewed
Jul 18, 2017
src/controller/deletecontent.js
Outdated
| @@ -32,8 +32,15 @@ export default function deleteContent( selection, batch, options = {} ) { | |||
| return; | |||
| } | |||
|
|
|||
| const selRange = selection.getFirstRange(); | |||
| // 0. Replace the entire content with paragraph. | |||
|
Some minor issues. |
|
Ready to review once again. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature:
DataController#deleteContentwill leave a paragraph if the entire content was selected and removed. Closes ckeditor/ckeditor5#4110.On the occasion
$rootelement has been as a limit element in Schema in order to simplify the checks.Additional information
Branch
t/ckeditor5-engine/1012inckeditor5-entershould be merged along with this PR.