Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force rendering bogus BR after UI elements #4143

Closed
scofalik opened this issue Aug 11, 2017 · 2 comments · Fixed by ckeditor/ckeditor5-engine#1073
Closed

Force rendering bogus BR after UI elements #4143

scofalik opened this issue Aug 11, 2017 · 2 comments · Fixed by ckeditor/ckeditor5-engine#1073
Assignees
@scofalik
Labels
package:engine type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 11

Comments

@scofalik
Copy link
Contributor

At the moment, an attribute element that is in otherwise empty container element receives bogus BR:

<p>
  <strong><br /></strong>
</p>

However it causes a problem when there is also a UI element in that container:

<p>
  <strong><br /></strong>
  <span class="myUi"></span>
</p>

Because the UI element is rendered incorrectly.

We should force rendering such attribute element after all UI elements. The attribute element should be pushed if its parent has no non-UI elements.
@scofalik scofalik self-assigned this Aug 11, 2017
@Reinmar
Copy link
Member

Reinmar commented Aug 11, 2017

What's your plan for this? We also have https://github.com/ckeditor/ckeditor5-engine/issues/1071 so if that can be fixed "by the way", it'd be lovely :D

@scofalik
Copy link
Contributor Author

scofalik commented Aug 11, 2017 •
edited
Loading

My plan for this is to make it quick. #4142 may need a bigger refactor and better planning.

pjasiun referenced this issue in ckeditor/ckeditor5-engine Aug 16, 2017
Merge pull request #1073 from ckeditor/t/1072
43b6ea9 
Fix: AttributeElement with bogus <br /> will now be placed after all UI elements which will fix how those elements are rendered. Closes #1072.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 11 milestone Oct 9, 2019
@mlewand mlewand added module:conversion type:improvement This issue reports a possible enhancement of an existing feature. package:engine labels Oct 9, 2019
@scofalik scofalik mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scofalik scofalik

Labels
package:engine type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 11
3 participants
@Reinmar @scofalik @mlewand