-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attributes hoisted to paragraph are not converted when selection is in another place #4142
Comments
The problem here is that we're converting attributes of the selection (which inherits attributes from the paragraph once it lands there). We'd need to somehow convert element attributes to attribute elements (fun with words!) too so those attribute elements don't disappear. |
I've pushed branch I don't like this solution much, I have a feeling that it is unstable / uncomplete (although it works and makes sense). It uses the same flow for selection conversion as it did, but:
We could try creating attribute elements for stored attributes during "normal conversion". It also makes sense and sounds more stable. But there is still problem with breaking and wrapping attributes because we have to do it if element is not empty. So I am afraid that we would need the same conditions anyway. |
There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue. |
There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue. |
We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it). |
This leads to breaking the X position of the caret:
The
<strong>
element should always be in that paragraph. That would allow the selection to natively land in there when pressing up/down arrows so we wouldn't need to fix it (breaking the X position).The text was updated successfully, but these errors were encountered: