Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Commit

Permalink
Docs: More docs fixes.
Browse files Browse the repository at this point in the history
  • Loading branch information
scofalik committed Jan 19, 2018
1 parent a300c1f commit dea9990
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 9 deletions.
8 changes: 3 additions & 5 deletions src/conversion/model-selection-to-view-converters.js
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,9 @@ export function convertRangeSelection() {
* <p><strong>f^oo<strong>bar</p>
* -> <p><strong>f</strong>^<strong>oo</strong>bar</p>
*
* By breaking attribute elements like `<strong>`, selection is in correct element. See also complementary
* {@link module:engine/conversion/model-selection-to-view-converters~convertSelectionAttribute attribute converter}
* for selection attributes,
* which wraps collapsed selection into view elements. Those converters together ensure, that selection ends up in
* appropriate attribute elements.
* By breaking attribute elements like `<strong>`, selection is in correct element. Then, when selection attribute is
* converted, the broken attributes might be merged again, or the position where the selection is may be wrapped
* in different, appropriate attribute elements.
*
* See also {@link module:engine/conversion/model-selection-to-view-converters~clearAttributes} which does a clean-up
* by merging attributes.
Expand Down
4 changes: 0 additions & 4 deletions src/conversion/modelconsumable.js
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,6 @@ export default class ModelConsumable {
* modelConsumable.add( modelElement, 'addAttribute:bold' ); // Add `bold` attribute insertion on `modelElement` change.
* modelConsumable.add( modelElement, 'removeAttribute:bold' ); // Add `bold` attribute removal on `modelElement` change.
* modelConsumable.add( modelSelection, 'selection' ); // Add `modelSelection` to consumable values.
* modelConsumable.add( modelSelection, 'selectionAttribute:bold' ); // Add `bold` attribute on `modelSelection` to consumables.
* modelConsumable.add( modelRange, 'range' ); // Add `modelRange` to consumable values.
*
* @param {module:engine/model/item~Item|module:engine/model/selection~Selection|module:engine/model/range~Range} item
Expand Down Expand Up @@ -149,7 +148,6 @@ export default class ModelConsumable {
* modelConsumable.consume( modelElement, 'addAttribute:bold' ); // Remove `bold` attribute insertion on `modelElement` change.
* modelConsumable.consume( modelElement, 'removeAttribute:bold' ); // Remove `bold` attribute removal on `modelElement` change.
* modelConsumable.consume( modelSelection, 'selection' ); // Remove `modelSelection` from consumable values.
* modelConsumable.consume( modelSelection, 'selectionAttribute:bold' ); // Remove `bold` on `modelSelection` from consumables.
* modelConsumable.consume( modelRange, 'range' ); // Remove 'modelRange' from consumable values.
*
* @param {module:engine/model/item~Item|module:engine/model/selection~Selection|module:engine/model/range~Range} item
Expand Down Expand Up @@ -181,7 +179,6 @@ export default class ModelConsumable {
* modelConsumable.test( modelElement, 'addAttribute:bold' ); // Check for `bold` attribute insertion on `modelElement` change.
* modelConsumable.test( modelElement, 'removeAttribute:bold' ); // Check for `bold` attribute removal on `modelElement` change.
* modelConsumable.test( modelSelection, 'selection' ); // Check if `modelSelection` is consumable.
* modelConsumable.test( modelSelection, 'selectionAttribute:bold' ); // Check if `bold` on `modelSelection` is consumable.
* modelConsumable.test( modelRange, 'range' ); // Check if `modelRange` is consumable.
*
* @param {module:engine/model/item~Item|module:engine/model/selection~Selection|module:engine/model/range~Range} item
Expand Down Expand Up @@ -220,7 +217,6 @@ export default class ModelConsumable {
* modelConsumable.revert( modelElement, 'addAttribute:bold' ); // Revert consuming `bold` attribute insert from `modelElement`.
* modelConsumable.revert( modelElement, 'removeAttribute:bold' ); // Revert consuming `bold` attribute remove from `modelElement`.
* modelConsumable.revert( modelSelection, 'selection' ); // Revert consuming `modelSelection`.
* modelConsumable.revert( modelSelection, 'selectionAttribute:bold' ); // Revert consuming `bold` from `modelSelection`.
* modelConsumable.revert( modelRange, 'range' ); // Revert consuming `modelRange`.
*
* @param {module:engine/model/item~Item|module:engine/model/selection~Selection|module:engine/model/range~Range} item
Expand Down

0 comments on commit dea9990

Please sign in to comment.