This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Editor UI classes API refactoring #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjasiun
reviewed
Jan 15, 2019
|
Make sure to rerun CI for this PR after merging ckeditor/ckeditor5-core#154 and ckeditor/ckeditor5-ui#458. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other: Editor UI classes API refactoring.
BREAKING CHANGE: Removed
InlineEditor#elementproperty. TheInlineEditorUI#elementproperty should be used instead.BREAKING CHANGE: Removed
InlineEditorUIView#editableElement. InsteadInlineEditorUI#getEditableElement()method should be used.Additional information
See ckeditor/ckeditor5#1449 and ckeditor/ckeditor5#1449 (comment) describing changes in each commit.
The CI should turn green after ckeditor/ckeditor5-core#154 is merged.