Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

t/ckeditor5/1838: Used the new EditorUI#setEditableElement() API in the DecoupledEditorUI class #36

Merged
merged 1 commit into from
Jun 28, 2019

Conversation

oleq
Copy link
Member

@oleq oleq commented Jun 27, 2019

Suggested merge commit message (convention)

Internal: Used the new EditorUI#setEditableElement() API in the DecoupledEditorUI class (see ckeditor/ckeditor5#1838).


A piece of ckeditor/ckeditor5#1840.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 267

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 35 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-56.04%) to 43.956%

Files with Coverage Reduction New Missed Lines %
packages/ckeditor5-editor-decoupled/src/decouplededitor.js 12 50.0%
packages/ckeditor5-editor-decoupled/src/decouplededitorui.js 23 29.27%
Totals Coverage Status
Change from base Build 265: -56.04%
Covered Lines: 33
Relevant Lines: 68

💛 - Coveralls

@oleq oleq marked this pull request as ready for review June 27, 2019 13:38
@jodator jodator merged commit 26c4ef1 into master Jun 28, 2019
@jodator jodator deleted the t/ckeditor5/1838 branch June 28, 2019 08:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants