-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix source maps generation for the UMD build. #991
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't say that UMD CKEditor 5 build works when preparing using changes from this PR:
at get parent (ckeditor5.js:5:175789)
at Wh._validate (ckeditor5.js:5:266719)
at Ju.<anonymous> (ckeditor5.js:5:350416)
at Ju.fire (ckeditor5.js:5:6572)
at <computed> [as applyOperation] (ckeditor5.js:5:38783)
at Pu.insert (ckeditor5.js:5:328486)
at Object.callback (main.js:51:11)
at Ju._runPendingChanges (ckeditor5.js:5:355920)
at Ju.change (ckeditor5.js:5:352975)
at main.js:48:16
So, it's the same as I reported via a private channel.
PS: We miss an issue that we could use as a reference to explain the problem. The proposed commit message does not explain the reason for the change. |
I added two UMD builds to trigger the Before changes:
After changes:
|
After reinstalling dependencies it looks good:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested - works as it should.
Suggested merge commit message (convention)
Fix (build-tools): Fixed source maps generation for the UMD build. Fixes ckeditor/ckeditor5#16984.
Feature (build-tools): Introduced a new
loadSourcemaps
plugin for loading source maps of external dependencies.