Preserve all selectors in CSS files during split into editor and content stylesheets. #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipsobol
approved these changes
Jul 10, 2024
|
Could I ask you to explain what the problem was? |
Will wrote an explanation when i finish the task, for now it's still WIP. |
…t into editor and content stylesheets.
|
@pomek I've updated the |
filipsobol
reviewed
Jul 16, 2024
| /** | ||
| * CSS rule type which are supported by this plugin. | ||
| */ | ||
| const SUPPORTED_RULE_TYPES = [ 'rule', 'media', 'keyframes' ]; |
There was a problem hiding this comment.
This is fine for now, but I worry that long-term we might miss other types.
|
Work will continue in #979. |
filipsobol
deleted the
unify-content-and-editor-stylesheets-with-one-included-all
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix (build-tools): Should preserve all selectors and at-rules in CSS files during split into
editorandcontentstylesheets. Closes ckeditor/ckeditor5#16703.Additional information
The main problem was when we were splitting main css file into
editorandcontent. Mainly it was done using.ck-contentCSS class as a main target what should be put intocontentfile and all the rest should land intoeditor. But this condition didn't include neither@mediaqueries or animations with@keyframesthat class contains.Currently all
@mediaqueries are splitted by class name mention above.The
@keyframesare gathered from whole main css file; also all selectors that are containinganimationoranimation-nameare gathered and compared in against selector that are used into. By this they can be correctly divided and added to desired css stylesheets.Also some CSS classes were omitted when there were more than one selector in definition. It's also fixed in this PR.