Added new task to verify if package was published correctly to npm. #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psmyrek
reviewed
Jul 4, 2024
packages/ckeditor5-dev-release-tools/lib/utils/publishpackageonnpmcallback.js
Outdated
Show resolved
Hide resolved
packages/ckeditor5-dev-release-tools/lib/tasks/verifypackagespublishedcorrectly.js
Outdated
Show resolved
Hide resolved
packages/ckeditor5-dev-release-tools/lib/tasks/verifypackagespublishedcorrectly.js
Outdated
Show resolved
Hide resolved
packages/ckeditor5-dev-release-tools/lib/tasks/verifypackagespublishedcorrectly.js
Outdated
Show resolved
Hide resolved
pomek
reviewed
Jul 4, 2024
packages/ckeditor5-dev-release-tools/lib/tasks/verifypackagespublishedcorrectly.js
Outdated
Show resolved
Hide resolved
pomek
reviewed
Jul 5, 2024
packages/ckeditor5-dev-release-tools/tests/utils/publishpackageonnpmcallback.js
Outdated
Show resolved
Hide resolved
psmyrek
reviewed
Jul 5, 2024
| const packageJson = await fs.readJson( upath.join( packageToVerify, 'package.json' ) ); | ||
|
|
||
| try { | ||
| await checkVersionAvailability( version, packageJson.name ); |
There was a problem hiding this comment.
checkVersionAvailability() returns a promise that resolves to true if the provided version does not exist or resolves the promise to false otherwise.
We should check the returned value here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature (release-tools): Added a new task to verify if packages were published correctly to npm. See ckeditor/ckeditor5#16625.
Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.