This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
It should be possible to disable autoformatting #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjasiun
reviewed
Jan 31, 2019
src/autoformat.js
Outdated
| * | ||
| * @type {Boolean} | ||
| */ | ||
| this.isEnabled = true; |
There was a problem hiding this comment.
I do not like this change. I think that autoformat should check if commands are enabled instead.
There was a problem hiding this comment.
While rewriting this feature to use commands only (researched in #7) seems impossible now, using commands to check whether a certain autoformat feature can be executed might indeed be feasible now.
|
Once again on the review... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature:
BlockAutoformatEditingwill not format if the command is disabled.InlineAutoformatEditingwill not format if the callback returnedfalse. Closes ckeditor/ckeditor5#2393.