Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ckeditor5 types in angular component. #358

Merged
merged 7 commits into from
Mar 30, 2023
Merged

Use ckeditor5 types in angular component. #358

merged 7 commits into from
Mar 30, 2023

Conversation

mremiszewski
Copy link
Contributor

@mremiszewski mremiszewski commented Mar 16, 2023 •
edited by pomek
Loading

Suggested merge commit message (convention)

Feature: Migrate package to TypeScript. Closes ckeditor/ckeditor5#13541.

MAJOR BREAKING CHANGE: Integration now requires Editor version 37 or later.

Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

@coveralls
Copy link

coveralls commented Mar 23, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 674

  • 25 of 25 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 631: 0.0%
Covered Lines: 157
Relevant Lines: 157
💛 - Coveralls

@pomek pomek mentioned this pull request Mar 27, 2023
Closed
arkflpc
arkflpc approved these changes Mar 28, 2023
View reviewed changes
Copy link

@arkflpc arkflpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Reinmar
Copy link
Member

Reinmar commented Mar 28, 2023

People are waiting ckeditor/ckeditor5#13773 ;)

psmyrek
psmyrek approved these changes Mar 29, 2023
View reviewed changes
Copy link
Collaborator

@psmyrek psmyrek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Demo apps in this repository use Angular 13+ and they work fine.
I created a new test app with Angular 15+ that uses changes from this PR and it works too.

So, LGTM 🎉

pomek
pomek approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@pomek pomek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

pomek
pomek requested changes Mar 30, 2023
View reviewed changes
Copy link
Member

@pomek pomek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typings from CKEditor 5 come with the latest CKEditor 5, which is 37.0.0 at this moment. We cannot use lower versions.

I will update it.

pomek
pomek approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@pomek pomek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pomek pomek merged commit a8342c9 into master Mar 30, 2023
@pomek pomek deleted the ck/13541-migrate-angular-integration-to-use-typed-ckeditor branch March 30, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pomek pomek pomek approved these changes

@arkflpc arkflpc arkflpc approved these changes

@psmyrek psmyrek psmyrek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TS] Migrate Angular integration to use generated typings
6 participants
@mremiszewski @coveralls @Reinmar @pomek @arkflpc @psmyrek