-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ckeditor5 types in angular component. #358
Use ckeditor5 types in angular component. #358
Conversation
Pull Request Test Coverage Report for Build 674
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
People are waiting ckeditor/ckeditor5#13773 ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Demo apps in this repository use Angular 13+ and they work fine.
I created a new test app with Angular 15+ that uses changes from this PR and it works too.
So, LGTM 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typings from CKEditor 5 come with the latest CKEditor 5, which is 37.0.0 at this moment. We cannot use lower versions.
I will update it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Suggested merge commit message (convention)
Feature: Migrate package to TypeScript. Closes ckeditor/ckeditor5#13541.
MAJOR BREAKING CHANGE: Integration now requires Editor version 37 or later.
Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.