Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated dependencies in the ckeditor5-angular repository #300

Merged
merged 3 commits into from
Feb 23, 2022
Merged

Conversation

psmyrek
Copy link
Collaborator

@psmyrek psmyrek commented Feb 23, 2022

Suggested merge commit message (convention)

Internal: Updated dependencies.


Additional information

  • So far, to build this repository npm v6.x was used, so in this PR also npm v6.x was used.

  • The npm audit status:

    • before: found 251 vulnerabilities (2 low, 129 moderate, 116 high, 4 critical)
    • after: found 76 vulnerabilities (2 low, 66 moderate, 8 high)
  • The CKE5-related packages were not bumped yet.

  • I tried to safely bump all other packages to their patch or minor versions.

  • There are ugly warnings after calling the tests. They are caused by the bumped log4js package:

    Zrzut ekranu 2022-02-23 073338

    To get rid of it, we could bump Karma to v6.x but for now this would be too big breaking change, so we must accept it for now.

  • All tests pass, manual verification also passed so IMHO it looks safe 😅

@psmyrek psmyrek requested a review from pomek February 23, 2022 07:16
@coveralls
Copy link

Pull Request Test Coverage Report for Build 434

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 419: 0.0%
Covered Lines: 141
Relevant Lines: 141

💛 - Coveralls

Copy link
Member

@pomek pomek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pomek pomek merged commit 1e1ffaa into master Feb 23, 2022
@pomek pomek deleted the ci/1479 branch February 23, 2022 08:09
@pomek pomek mentioned this pull request Mar 9, 2022
@pomek pomek mentioned this pull request Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants