Prevent ckeditor component from calling CVA onChange when the change comes from the CVA #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e comes from the CVA.
|
@ma2ciek FYI It also fixes template driven dirty flag being set after ngModel "reset" https://stackblitz.com/edit/angular-ckeditor-form-dirty . Any ETA on a new release of ckeditor5-angular ? I'm waiting for this fix :) thanks |
|
@antoinebrault, I've seen it too :) I'll try to release it within this week. I was hoping that #143 can be solved before the release too, but the proper solution for it seems to be a bit tough and fragile change in the codebase, thus I want to release the latter separately. |
|
Update: The latest release includes the fix - |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix: The
<ckeditor>component won't call the CVAregisterOnChange()when the change comes from the CVA. This will fix an issue with changing data in Reactive Forms. Closes #139.Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.