-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The component works slow on large documents #141
Comments
cc @ma2ciek |
I've checked it and the reason, I think, is that the editor's change event triggers the I've checked and nothing breaks if I remove this callback. Although, according to docs this fn should be called to reenter the angular zone and to emit the event inside it. 🤷♂ |
Thanks for the reply! What solution would you like to see as an PR? Introduce a new property to disable the on-change function all together and manually call |
I guess, that this line can actually be removed, but I need to be sure that nothing breaks after this change. |
Although the PR is not finished, I did do some checking to make sure this actually resolves the issue. It certainly does make a huge difference when working with large text files, a delay is still noticeable when blurred because that is the moment the |
I encounter the same issue... I search more informations on this but nothing help me tio solve this issue. Thanks |
Perhaps the only solution currently is to limit the data loaded in the editor and split it into chapters or some other smaller things. |
Thanks ma2ciek for reply. |
Same issue here... (...except that without two-way binding it will be very very cumbersome here...) |
This issue is still blocked by the upstream issue - improving the |
Could we remove two-way data binding in favor of synchronous changes using the |
Feature: Added an optional option called `disableTwoWayDataBinding` that allows disabling the two-way data binding. It increases performance when working with large documents. Closes #141.
While the upstream issue is still open, we wanted to improve the developer experience using CKEditor 5 and the Angular integration. I would like to announce we added a new option called Changes: #346 We will release these changes this week. I will make sure to keep you posted. |
Similar issues:
ckeditor/ckeditor5-vue#42
And:
ckeditor/ckeditor4#449
But then for CKEditor 5 and angular. I am experiencing the same issues and wonder how to fix this? I guess this has been brought up before but I can't seem to find any related topics on this.
This can easily be re-produced by opening the default template for angular ckeditor:
https://stackblitz.com/edit/angular-ckeditor
And paste large amount of text in it. Go to https://www.lipsum.com/, put paragraphs on 150 and just start copy-pasting that text into the edtior. Around 5 or 6 times it becomes slower. The more lines you have, the more slower it becomes.
I have tried to remove the
[data]
property so that there is no two-way binding, but I guess, just like in the vue project, there is an issue with the on-change detection.The text was updated successfully, but these errors were encountered: