Upload Widget crash #967
Closed
Upload Widget crash #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlewand
added
the
review:easy
msamsel
reviewed
Sep 28, 2017
| @@ -251,8 +251,9 @@ | |||
|
|
|||
| loader.on( 'update', function( evt ) { | |||
| // Abort if widget was removed. | |||
| if ( !widget.wrapper || !widget.wrapper.getParent() ) { | |||
| if ( !editor.editable().find( '[data-cke-upload-id="' + id + '"]' ).count() ) { | |||
| if (!widget.wrapper || !widget.wrapper.getParent()) { | |||
msamsel
suggested changes
Sep 28, 2017
There was a problem hiding this comment.
Hi,
thank you for your pull request. There is still few improvements, which might be done, before your pull request will be possible to merge. General information about contributing you can find here in our guide. Those things currently are missing in your pull request:
- All changes in CKEditor requires tests. Please provide proper unit and manual tests. More information about tests you can find under this link
- Please also remember to sign CLA (it should be send on your email). Without it we cannot implement any changes made by you.
mlewand
approved these changes
Jul 19, 2018
|
This PR was merged manually with 33d301f. Thanks for the input, and sorry for the delay it's been a busy period for us 🙂 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Bug fix
What changes did you make?
Added extra condition
Fix for #966