CKEDITOR.plugins.link.getSelectedLink does not fetch all links #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comandeer
changed the title
Comandeer
requested changes
Oct 6, 2017
There was a problem hiding this comment.
There is one case that it's still not working:
<table border="1" cellpadding="1" cellspacing="1" style="width:500px">
<tbody>
<tr>
<td> </td>
<td> </td>
</tr>
<tr>
<td><a href="http://gagahahahahah"><img alt="" src="https://www.comandeer.pl/images/custom/comandeer.jpg" style="height:96px; width:96px" />hahahahahahah</a></td>
<td> </td>
</tr>
<tr>
<td> </td>
<td> </td>
</tr>
</tbody>
</table>In that case double clicking the link does not fetch it.
| 1. Right-click on the span ("some button text") and select "Edit Link". | ||
|
|
||
| **Expected:** | ||
| * Link should have class `someClass`. |
There was a problem hiding this comment.
Class described here is not the same as the class used inside the code.
| </div> | ||
|
|
||
| <script> | ||
| CKEDITOR.replace( 'editor' /*,{ allowedContent: true }*/); |
There was a problem hiding this comment.
This commented code should be deleted.
| bot.editor.getSelection().selectElement( editable.findOne( 'a' ) ); | ||
|
|
||
| bot.dialog( 'link', function( dialog ) { | ||
| assert.areSame( dialog.getValueOf( 'info', 'url' ), 'linkUrl' ); |
There was a problem hiding this comment.
It would be nice to close the dialog after the test.
|
I was not able to reproduce this issue with table. The table is now available in manual test. @Comandeer please check this again to confirm. |
Comandeer
force-pushed
the
t/859
branch
3 times, most recently
from
a63ccb3
to
16a4c79
Compare
Comandeer
approved these changes
Dec 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Bug fix
Does your PR contain necessary tests?
All patches which change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.
This PR contains
What changes did you make?
Fix double click on anchor with image and text.
closes #859