Cannot set cell width or height because inline styles are stripped #722
Conversation
f1ames
changed the title
| @@ -150,6 +153,10 @@ CKEDITOR.dialog.add( 'cellProperties', function( editor ) { | |||
| inputElement = this.getInputElement(), | |||
| ariaLabelledByAttr = inputElement.getAttribute( 'aria-labelledby' ); | |||
|
|
|||
| if ( this.getDialog().getContentElement( 'info', 'height' ).isVisible() ) { | |||
There was a problem hiding this comment.
When height is not supported, the label should also be hidden (e.g. display: none), as for now it creates some gap in a dialog so the elements are not aligned correctly:
| @@ -129,6 +129,64 @@ | |||
| dialog.setValueOf( 'info', 'width', 10 ); | |||
| dialog.setValueOf( 'info', 'widthType', 'px' ); | |||
| } ); | |||
| }, | |||
|
|
|||
| 'test test': function() { | |||
There was a problem hiding this comment.
This is strange name for a test :)
Also this test fails on FF, IE9.
| bender.editorBot.create( { | ||
| name: 'required', | ||
| config: { | ||
| allowedContent: { |
There was a problem hiding this comment.
I am not sure, but maybe it can be replaced with something like:
allowedContent: *[lang,dir]; table tbody tr...
Test with disallowedContent rule should be added too.
| @@ -0,0 +1,11 @@ | |||
| @bender-tags: 4.7.0, 16893 tc | |||
There was a problem hiding this comment.
Please update tags to 4.7.2, trac16893, bug
|
|
||
| ## Expected | ||
|
|
||
| Cell width and height fields are not displayed. |
There was a problem hiding this comment.
Cell width and height fields are not visible. All dialog elements are properly aligned (no gap at the top in one of the columns).
TODO:
|
What is the purpose of this pull request?
Bug fix
Does your PR contain necessary tests?
All patches which change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.
This PR contains
What changes did you make?
Closes #1014.