-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for lack of cache key for some resources #4852
Conversation
….tools.buildStyleHtml()`.
…uildStyleHtml()` use `CKEDITOR.getUrl()` internally and update their API docs accordingly.
….getUrl()` is no longer needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've also changed the default value of
config.contentsCss
as wrapping it in CKEDITOR.getUrl() is no longer needed (not sure if we should add info about it to changelog or some notification in API docs?).
I think we don't have to mention that anywhere - since the final result will be the same.
It is nice that you covered old functionality with tests :)
I left just two small comments. Tests on building editor seems to be working fine 👍
Co-authored-by: Bartłomiej Kalemba <[email protected]>
Co-authored-by: Bartłomiej Kalemba <[email protected]>
I've applied all your suggestions. Thanks for doing the work for me ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 🎉
Nice job - we have another bug down :D
Revert "Merge pull request #4852 from ckeditor/t/4761"
What is the purpose of this pull request?
Bug fix
Does your PR contain necessary tests?
All patches that change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.
This PR contains
Did you follow the CKEditor 4 code style guide?
Your code should follow the guidelines from the CKEditor 4 code style guide which helps keep the entire codebase consistent.
What is the proposed changelog entry for this pull request?
What changes did you make?
I've used
CKEDITOR.getUrl()
insideCKEDITOR.tools.buildStyleHtml()
(used to loadconfig.contentsCss
files) andCKEDITOR.dom.document#appendStyleSheet()
(used to add stylesheets in plugin) to add the cache key to every CSS file.I've also changed the default value of
config.contentsCss
as wrapping it inCKEDITOR.getUrl()
is no longer needed (not sure if we should add info about it to changelog or some notification in API docs?). I've added some basic tests forCKEDITOR.getUrl()
as well – apparently it wasn't tested until now.As it's a potentially breaking change I'll target it to
major
instead ofmaster
.Which issues does your PR resolve?
Closes #4761.