Fix: Autogrow plugin causing width of editor's container to be set to 0px

[hub33k]

What is the purpose of this pull request?

Bug fix

Does your PR contain necessary tests?

All patches that change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.

This PR contains

• Unit tests
• Manual tests

Did you follow the CKEditor 4 code style guide?

Your code should follow the guidelines from the CKEditor 4 code style guide which helps keep the entire codebase consistent.

• PR is consistent with the code style guide

What is the proposed changelog entry for this pull request?

* [#4286](https://github.com/ckeditor/ckeditor4/issues/4286): validate if width is valid value in editor.resize function.

What changes did you make?

Check if width has valid value.

Which issues does your PR resolve?

Closes #4286.

[grumd]

We also encountered this issue in our project that's using CKEditor. Looking forward to see this merged soon.

Is there a way to use an older version of CKEditor in the online builder? (https://ckeditor.com/cke4/builder)
It only gives an option of using the latest version that's currently bugged.

[f1ames]

Is there a way to use an older version of CKEditor in the online builder? (https://ckeditor.com/cke4/builder)
It only gives an option of using the latest version that's currently bugged.

@vokiel correct me if I'm wrong, but I don't think it's doable with online builder. @grumd you would need to create CKEditor 4 build "manually" (using ckeditor4-presets repo).

[grumd]

@f1ames That repo seems to only support building the three default presets (basic/standard/full), but I found that it's possible to build ck4 code by checking out the branch/tag you need, and running /dev/builder/build.sh and using a custom /dev/builder/build-config.js. But I'd rather have the latest version so I'll wait a while for this PR first.

[vokiel]

I don't think it's doable with online builder.

True, the online builder works with the latest version only.

[hub33k]

@grumd you can create customized presets by creating two files: presets/$1-build-config.js & presets/$1-ckeditor-config.js (replace $1 with preset name) - ckeditor/ckeditor4-presets@2e89eb0.

[f1ames]

Looks good 👍

Only some polishing in unit tests needed - I don't see a reason to keep both unit tests in separate files so it will be good to merge them into one. See also review comments.

[f1ames]

Rebased onto latest master.

[f1ames]

LGTM 👍

[grumd]

Great work! Any ETA on when a new release may happen with this PR included?

[f1ames]

@grumd no definite ETA so far, but we are targeting beginning of December.