Prevent of throwing an error when is no selection. #359
Conversation
beatadelura
changed the title
| @@ -0,0 +1,18 @@ | |||
| @bender-tags: 4.7.1, 16874 | |||
There was a problem hiding this comment.
The manual test only covers the issue case on Chrome (there is no selection when pressing enter) while in other browsers the selection exists and cannot be removed/dismissed by clicking inside of the editor.
Maybe it would be possible to add a second scenario for the test which will be covering button removing selection/ranges from the editor to check if enter does not produce an error then (similar as in unit test).
The exampe of test with more than one scenario: https://github.com/ckeditor/ckeditor-dev/blob/master/tests/plugins/clipboard/manual/13883.md.
Keep in mind that after pressing button outside of the editor, the editor loses focus - probably clicking should first focus the editor and then remove selection.
| @@ -521,7 +521,8 @@ | |||
| // Check path block specialities: | |||
| // 1. Cannot be a un-splittable element, e.g. table caption; | |||
| var path = editor.elementPath(); | |||
| if ( !path.isContextFor( 'p' ) ) { | |||
|
|
|||
| if ( path && !path.isContextFor( 'p' ) ) { | |||
There was a problem hiding this comment.
There is similar issue #357 and @Comandeer mentioned a more generic approach there which may cover all those cases, which is generally a good approach. The cause of the issue is the fact that enter key press is handled while there is no selection (while editable area is focused). This is however a responsibility of the core to handle such situations and enterkey plugin by itself also should do some additional checkings as above.
Having said that, I think this check is sufficient for this case.
|
@f1ames PTAL |
|
LGTM! I just added some small changes in tests. |
|
Rebased with latest |
http://dev.ckeditor.com/ticket/16874
Closes #478