Improve stability of Paste Tools tests with filters #3539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f1ames
suggested changes
Nov 15, 2019
There was a problem hiding this comment.
It looks good and works fine on CI from what I can see. However... I would assume it will also fix failing tests on Edge, but it still seems to be an issue (below tests fails randomly):
I had new virtual machine set up so there were no cached version of master branch. Not sure what more we can do here 😕
|
I'm not sure if it's worth fixing, as Edge is switching to Chromium at the beginning of the next year. |
f1ames
approved these changes
Nov 18, 2019
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Failing test
Does your PR contain necessary tests?
All patches which change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.
This PR contains
What is the proposed changelog entry for this pull request?
None needed.
What changes did you make?
I've moved loading filters as a part of
async:initto force loading them after creating editor for tests.Closes #3424.