Fix for incorrect selection when styling table using native selection #3038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was implemented due to the bug in Chrome: https://bugs.chromium.org/p/chromium/issues/detail?id=353069 For some selections, Chrome displayed error in the console and this code prevented that. |
|
Rebased onto latest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Bug fix
Does your PR contain necessary tests?
All patches which change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.
This PR contains
What changes did you make?
I removed the code responsible for selecting detached DOM elements. The issue has been introduced with d4907f5634 commit as a part of https://dev.ckeditor.com/ticket/16755 feature.
I couldn't spot any issues after code removal nor manual or unit tests referencing the issue from comment. Not sure why it has been implemented in the first place. I can only suppose that it has been fixed by some editor changes.
Closes #941