Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for "bodyClass" and "bodyId" settings in Styles dropdown #297

Conversation

aik099
Copy link

@aik099 aik099 commented Oct 17, 2016

@aik099
Copy link
Author

aik099 commented Oct 30, 2016

Any updates?

@Tade0
Copy link
Contributor

Tade0 commented Dec 23, 2016

Thanks for the PR!

Would you like to help us further by including some tests(a manual test is fine in this case).

Here's a guide just in case: http://docs.ckeditor.com/#!/guide/dev_contributing_code

@aik099
Copy link
Author

aik099 commented Dec 23, 2016

What you mean by manual test? Using provided link I've found explanation how to create tests using Bender, but not manual ones.

@mlewand
Copy link
Contributor

mlewand commented Jan 4, 2017

@aik099 Now I can see it's not exposed well enough, there's a paragraph:

Some type of features or bugs cannot be tested automatically. In such cases, make sure to create a manual test (see this one for instance).

Which links to https://github.com/ckeditor/ckeditor-dev/tree/master/tests/tickets/12735 as an example. This helps us more quickly to check if the code actually fixes the problem for end user, and is also used by QA again during the final release.

I'll make sure that docs get updated there.

@mlewand
Copy link
Contributor

mlewand commented Jul 25, 2018

Hi, It's been a while since we last heard from you and the tests were not added. We're closing this PR for now. Still, feel free provide us requested feedback, so that we can reopen this PR.

@mlewand mlewand closed this Jul 25, 2018
@mlewand mlewand added the resolution:expired Issue reporter did not provide enough information to reproduce the issue for at least 2 weeks. label Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resolution:expired Issue reporter did not provide enough information to reproduce the issue for at least 2 weeks. tests needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants