Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for: focused input in dialog is scrolled out of viewport when soft keyboard appears #2413

Merged
merged 77 commits into from
Sep 9, 2019
Merged

Fix for: focused input in dialog is scrolled out of viewport when soft keyboard appears #2413

Show file tree
Hide file tree
Changes from 76 commits
Commits
Show all changes
77 commits
Select commit Hold shift + click to select a range
2e9c854
Tests: Added manual test.
engineering-this Sep 13, 2018
5a03d34
Fixed: focusing dialogs input moves scrolls input outside of viewport.
engineering-this Sep 13, 2018
b283fb9
Fixed type error on IE8
engineering-this Sep 13, 2018
99531d5
Refactoring: handleBodyStyles split and renamed into showBodyScrollba…
engineering-this Sep 19, 2018
df82bdc
Fixed scrollbars appearing when resizing dialog.
engineering-this Sep 19, 2018
4116a46
Fixed issue with extra padding when padding is predefined on body.
engineering-this Sep 20, 2018
8165e31
Tests: added test.
engineering-this Sep 20, 2018
54b6577
Updated skins to match dialog changes.
engineering-this Sep 20, 2018
7911cd9
Typo
engineering-this Sep 20, 2018
97bd5a7
Tests: added manual test for each skin.
engineering-this Sep 20, 2018
b86067b
Separated setStyle from return statement.
engineering-this Sep 24, 2018
3bef599
Removed adding right padding for covering removed scrollbars.
engineering-this Sep 25, 2018
c2f362f
Removed resizeCover method, it is now rezised with css.
engineering-this Sep 25, 2018
ef2ef74
Typo.
engineering-this Sep 25, 2018
4f8e300
Moved initial styles to template.
engineering-this Sep 25, 2018
da4018a
Removed redundant position style.
engineering-this Sep 26, 2018
02fee18
Tests: updated after changes.
engineering-this Sep 26, 2018
bfba472
Tests: fixed failing on very small window.
engineering-this Sep 26, 2018
1cfbc2f
Removed code which is redundant after changes.
engineering-this Sep 26, 2018
0f2d2a4
Removed oneliner functions.
engineering-this Sep 26, 2018
a78ee71
Transformed pixel coordinates into percentage.
engineering-this Oct 3, 2018
474702a
Tests: fixed failing on IE.
engineering-this Oct 3, 2018
e774a57
Removed var declaration and moved it inline into fn call.
engineering-this Oct 3, 2018
330df4c
Restored window resize listener. Dialog position will be updated when…
engineering-this Oct 8, 2018
e19e5bc
Tests: bumped tag version.
engineering-this Oct 12, 2018
1e84248
Tests: refactored and removed comments.
engineering-this Oct 12, 2018
47068ef
Tests: added comments.
engineering-this Oct 12, 2018
c31924d
Renamed variable.
engineering-this Oct 12, 2018
dbc4a62
Tests: added test case.
engineering-this Oct 12, 2018
d169376
Tests: removed dialog.hide call in tests as it has been moved to tear…
engineering-this Oct 12, 2018
8bfed0c
Free space which is uses for dialog positioning calculations can't be…
engineering-this Oct 15, 2018
78eb088
Moved variable dialogViewportRatio from plugin scope to instance priv…
engineering-this Nov 9, 2018
3c87248
Changelog: added dialog plugin link.
engineering-this Nov 9, 2018
ed628c4
Merged two line comment into one line.
engineering-this Nov 9, 2018
ab7fd74
Tests: updated version tag.
engineering-this Nov 9, 2018
236396a
Tests: added missing ticket reference.
engineering-this Nov 9, 2018
3dab48d
Tests: fixed test failing when run form dashboard. Extracted duplicat…
engineering-this Nov 9, 2018
1cff428
Tests: ignored on mobiles.
engineering-this Nov 9, 2018
21576a9
Tests: fixed failing test on IE8.
engineering-this Nov 9, 2018
b97517e
Tests: added rtl editor.
engineering-this Nov 9, 2018
7a666af
Tests: split test into two, one for mobiles and one for desktops.
engineering-this Nov 9, 2018
bce7594
Extracted repeated conditional to useFlex variable.
engineering-this Jan 9, 2019
c3b1cf0
Tests: updated version tags.
engineering-this Jan 9, 2019
4c307b9
Tests: rephraased test steps.
engineering-this Jan 9, 2019
82b9eb3
Tests: added empty lines between each test.
engineering-this Jan 9, 2019
4d1c17c
Tests: updated version tag.
engineering-this Mar 7, 2019
c92c917
Unwrap redundant IIFE.
engineering-this May 30, 2019
e051502
Remove redundant doubled brackets, add if braces.
engineering-this May 30, 2019
9fea79b
Fixed: dialog can be resized out of viewport.
engineering-this May 30, 2019
4f8e0a5
Fallback position to 0.
engineering-this May 30, 2019
0c40070
Fix positioning of dragged dialog after resize.
engineering-this May 30, 2019
5b68c70
Move dialog specific styles from skins, to plugin stylesheet.
engineering-this May 30, 2019
7c8d86c
Revert improvements to dialog tab list styling, because it would be n…
engineering-this May 30, 2019
aea321e
Remove redundant brackets.
engineering-this May 31, 2019
3d326d6
Fix type error in IE.
engineering-this May 31, 2019
b2d582b
Remove ie6compat code that became redundant after changes.
engineering-this May 31, 2019
f5f3172
Tests: update version tag.
engineering-this Jul 23, 2019
9fd73a8
Tests: update version tag.
engineering-this Jul 23, 2019
860e70a
Tests: update version tag.
engineering-this Jul 23, 2019
6b00c43
Tests: update version tag.
engineering-this Jul 23, 2019
5aeb6e0
Tests: update version tag.
engineering-this Jul 23, 2019
6aeaf8f
Fix dialog getting out of viewport when resizing window.
engineering-this Jul 23, 2019
f0b9a9b
Fix dialog not being resizable to the edge of viewport.
engineering-this Jul 24, 2019
2b0ca13
Refactoring, reuse existing functions/variables.
engineering-this Jul 24, 2019
c96a2d9
Tests: add more information about dialog behaviour when window is res…
engineering-this Jul 24, 2019
eb2d685
Replace use of viewport size with container size. Reason for that is …
engineering-this Jul 24, 2019
85ed730
Add getClinetsize method.
engineering-this Jul 24, 2019
fb829f1
Use new dom.element.getClientSize instead of local helper.
engineering-this Jul 24, 2019
bfaedbd
Tests: fix tests after chagnes.
engineering-this Jul 24, 2019
89912aa
Tests: add test case.
engineering-this Jul 24, 2019
59f01db
Fix referrence error.
engineering-this Aug 28, 2019
813cf16
Code style, missing space.
engineering-this Aug 28, 2019
fca1925
Fix dialog being resizible out of viewport in RTL editors.
engineering-this Aug 28, 2019
eaff5a8
Remove leftover.
engineering-this Aug 28, 2019
8805f18
Add meta tag to test. Add note.
engineering-this Aug 28, 2019
7e45fc6
Don't use convertToPx on value with 'px', parseInt is sufficient.
engineering-this Aug 28, 2019
16202c0
Updated changelog entries. [skip ci]
f1ames Sep 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ Fixed Issues:
* [#3379](https://github.com/ckeditor/ckeditor-dev/issues/3379): Fixed: Incorrect [`CKEDITOR.editor#getData`](https://ckeditor.com/docs/ckeditor4/latest/api/CKEDITOR_editor.html#method-getData) call when inserting content into the editor.
* [#3136](https://github.com/ckeditor/ckeditor-dev/issues/3136) [Firefox] Fixed: Clicking on [Balloon Toolbar](https://ckeditor.com/cke4/addon/balloontoolbar) items removes native table selection.
* [#3381](https://github.com/ckeditor/ckeditor-dev/issues/3381): [IE8] Fixed: [`CKEDITOR.tools.object.keys`](https://ckeditor.com/docs/ckeditor4/latest/api/CKEDITOR_tools_object.html#method-keys) does not accept non-objects.
* [#2395](https://github.com/ckeditor/ckeditor-dev/issues/2395): Fixed: focused input in [dialog](https://ckeditor.com/cke4/addon/dialog) is scrolled out of viewport when soft keyboard appears.

API Changes:

Expand Down
13 changes: 13 additions & 0 deletions core/dom/element.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -682,6 +682,19 @@ CKEDITOR.dom.element.clearMarkers = function( database, element, removeFromDatab
return new CKEDITOR.dom.nodeList( this.$.childNodes );
},

/**
* Gets the elements `clientWidth` and `clientHeight`.
*
* @since 4.13.0
* @returns {Object} An object containing width and height values.
*/
getClientSize: function() {
return {
width: this.$.clientWidth,
height: this.$.clientHeight
};
},

/**
* Gets the current computed value of one of the element CSS style
* properties.
Expand Down
Loading