Fixed issues with applying inline styles to HTML comments #2381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comandeer
requested changes
Sep 6, 2018
| @@ -0,0 +1,20 @@ | |||
| @bender-tags: bug, 2296, 4.10.1 | |||
There was a problem hiding this comment.
I suppose I'm going to mix these two till the end of time. 😉 Fixed in 586cf64.
tests/core/style/applyremove.js
Outdated
| test_inline_nobreak1: function() { | ||
| playground.setHtml( 'this is <a href="http://example.com/">some sample</a> text' ); | ||
|
|
||
| var range = new CKEDITOR.dom.range( doc ); | ||
| range.setStart( playground, 0 ); | ||
| range.setEnd( playground.getChild( 1 ).getFirst(), 4 ); | ||
|
|
||
| playground.trim(); |
There was a problem hiding this comment.
Is this change needed? Checked in Chrome, Firefox, Safari and IE 8 – nothing failed without it.
There was a problem hiding this comment.
No, it's no longer needed. It was just a leftover I made when cleaning up markup for IE8. Several tests required to strip bounding whitespaces, as otherwise extra paragraphs were created. Dropped in 5fca69d.
…few simplifications the content was gone. I'll probably simplify it in next commits.
Now it starts to look nice.
…them with the style. The reason is to simply produce a cleaner markup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Bug fix
Does your PR contain necessary tests?
All patches which change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.
This PR contains
What changes did you make?
While checking #2294 bug I found that HTML comments are badly handled.
First I had a fix in 85b89ec - which fixed the issue requested in #2294 but I wasn't quite happy about the way how it did it. For instance, applying strong to the following HTML:
Would result with:
It could be acceptable to some extend, but it's pretty dirty HTML nontheless so I dig deeper, and after some further checking I was able to create a more clean result:
Also you might note that in 7da825e I have reverted some refactoring. Imho name
checkIfTextOrReadonlyOrEmptyElementis not the prettiest, personally I'd use sth likeif ( isText( foo ) || isReadonly( foo ) || ( isEmpty( foo ) and isElement( foo ) ) )- but decided to revert it, to make just essential changes (except some doc typos cleanup).Closes #2294 and closes #2380.