Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config to map smileys to one or more BBcode-representations. #224

Closed
wants to merge 1 commit into from

Conversation

mandark
Copy link

@mandark mandark commented Oct 18, 2015

hi there!

until now the mappings of smileys to their BBcode-representations was hardcoded into the BBcode-plugin. this resulted in errors when adding or modifying the smileys via the configs of the smiley-plugin.

additionally, this mapping was a 1:1 mapping, meaning e.g. the bbcode ":(" would map to the "sad"-smiley, but the bbcode ":-(" wouldn't.

my changes introduce a new config-setting (config.bbode_smiley_map), which allows mapping of a smiley (via it's description defined in config.smiley_descriptions) to one or more BBcode-representations.

i guess this would also close the ticket 8198.

best wishes,
mandark

…n to one or more BBcode-representations with the BBcode-plugin
@mlewand
Copy link
Contributor

mlewand commented Jul 30, 2018

Hello @mandark, thanks for the contribution. Sorry that we're reviewing this PR that late (actually it's one of the oldest PRs here).

Since few years passed by now, the web is now going with Emojis, thus it renders our Smileys plugin deprecated. That's the reason why we introduced new CKEditor 4 Emoji plugin in 4.10.0.

Also the very feature that you're requesting here has been proposed in 4.11.0 enhancements for Emoji plugin (see "Turning Popular Matches into Emoji" section). As such this is where we want to put this feature, rather than the Smileys/BBCode plugin.

If you'd still wish to have it integrated with Smileys/BBCode only, your best option is to create a new plugin. You could also publish it in our Addons Repository!

@mlewand mlewand closed this Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants