Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make manual tests for plugins configuration mobile- & built-friendly #1995

Merged
merged 1 commit into from
Jun 21, 2018

Conversation

Comandeer
Copy link
Member

What is the purpose of this pull request?

Failing test/task

Does your PR contain necessary tests?

All patches which change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.

This PR contains

  • Unit tests
  • Manual tests

It's just fix for manual tests.

What changes did you make?

I've made manual tests for #1712 mobile friendly. They also pass in built version now.

I didn't change unit tests as they got fixed in #1929.

Closes #1994.

@mlewand mlewand self-requested a review June 21, 2018 15:04
Copy link
Contributor

@mlewand mlewand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mlewand mlewand merged commit 19f0a99 into major Jun 21, 2018
@mlewand mlewand deleted the t/1994 branch June 21, 2018 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing manual tests for handling whitespace plugins configuration in built CKE version
2 participants