Add onHide doc #1748
Closed
Add onHide doc #1748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlewand
added
the
review:easy
jacekbogdanski
approved these changes
Mar 7, 2018
mlewand
approved these changes
Mar 12, 2018
| @@ -128,6 +128,12 @@ | |||
| * @property {Function} onShow | |||
| */ | |||
|
|
|||
| /** | |||
| * The function to execute when the dialog is hidden (executed every time the dialog is closed). | |||
There was a problem hiding this comment.
This could be simplified down to:
The function executed every time the dialog is closed.
I'll correct this while merging.
|
Merged with 011af64 - it will be published in 4.10.0. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Add lacking documentation. The "onHide" property of dialogDefinition is used (for example, plugins/link/dialogs/anchor.js) but it's not described in dialogDefinition.js.
Does your PR contain necessary tests?
No. This PR add a comment only.
What changes did you make?
Add a doc comment to dialogDefinition.js.