Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Paste notification isn't very straightforward and it might confuse users #1601

Merged
merged 3 commits into from
Feb 8, 2018

Conversation

engineering-this
Copy link
Contributor

What is the purpose of this pull request?

Task

Does your PR contain necessary tests?

All patches which change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.

This PR contains

  • Unit tests
  • Manual tests
    Updated description in existing test, so it covers this PR

What changes did you make?

I've changed paste notification in lang files for paste and clipboard plugins, to

Press %1 to paste. Your browser doesn't support pasting with the toolbar button or context menu option.

Which was most upvoted in that discussion.

Closes #1363

Copy link
Member

@Comandeer Comandeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not all language files were changes (e.g. de or ru in both plugins were not touched).

@mlewand
Copy link
Contributor

mlewand commented Feb 8, 2018

@engineering-this @Comandeer let's also change it for other langs as @Comandeer pointed out. Eventually these will be overwritten by Transifex during the language sync.

@Comandeer
Copy link
Member

Please rebase onto latest major as there are conflicts.

Copy link
Member

@Comandeer Comandeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Comandeer Comandeer merged commit b6ebcdc into major Feb 8, 2018
@Comandeer Comandeer deleted the t/1363 branch February 8, 2018 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants