Fixed: [tableselection] table contents can be removed in a readonly mode

CHANGES.md

@@ -7,6 +7,7 @@ Fixed Issues:
 
 * [#1181](https://github.com/ckeditor/ckeditor-dev/issues/1181): [Chrome] Fixed: Opening context menu in readonly editor results in error.
 * [#2276](https://github.com/ckeditor/ckeditor-dev/issues/2276): [iOS] Fixed: [Button](https://ckeditor.com/cke4/addon/button) state doesn't refresh properly.
+* [#1489](https://github.com/ckeditor/ckeditor-dev/issues/1489): Fixed: [Table Selection](https://docs.ckeditor.com/ckeditor4/latest/api/CKEDITOR_plugins_tableselection.html) table contents can be removed in readonly mode.
 
 ## CKEditor 4.10.1
 

plugins/tableselection/plugin.js

@@ -974,7 +974,8 @@
 						i;
 
 					// Handle only left/right/del/bspace keys.
-					if ( !keystrokes[ key ] ) {
+					// Disable editing cells in readonly mode (#1489).
+					if ( !keystrokes[ key ] || editor.readOnly ) {
 						return;
 					}
 
@@ -1043,6 +1044,11 @@
 					firstCell,
 					i;
 
+				// Disable editing cells in readonly mode (#1489).
+				if ( editor.readOnly ) {
+					return;
+				}
+
 				// We must check if the event really did not produce any character as it's fired for all keys in Gecko.
 				if ( !selection || !selection.isInTable() || !selection.isFake || !isCharKey ||
 					evt.data.getKeystroke() & CKEDITOR.CTRL ) {

tests/plugins/tableselection/manual/readonly.html

@@ -0,0 +1,32 @@
+<div id="editor1">
+	<table border="1">
+		<tr>
+			<td>Cell 1.1.1</td>
+			<td>Cell 1.1.2</td>
+			<td>Cell 1.1.3</td>
+			<td>Cell 1.1.4</td>
+		</tr>
+		<tr>
+			<td>Cell 1.2.1</td>
+			<td>Cell 1.2.2</td>
+			<td>Cell 1.2.3</td>
+			<td>Cell 1.2.4</td>
+		</tr>
+		<tr>
+			<td>Cell 1.3.1</td>
+			<td>Cell 1.3.2</td>
+			<td>Cell 1.3.3</td>
+			<td>Cell 1.3.4</td>
+		</tr>
+	</table>
+</div>
+
+<script>
+	if ( bender.tools.env.mobile || CKEDITOR.env.ie && CKEDITOR.env.version < 11 ) {
+		bender.ignore();
+	}
+
+	CKEDITOR.replace( 'editor1', {
+		readOnly : true
+	} );
+</script>

tests/plugins/tableselection/manual/readonly.md

@@ -0,0 +1,17 @@
+@bender-ui: collapsed
+@bender-tags: 1489, 4.10.2, bug
+@bender-ckeditor-plugins: wysiwygarea, toolbar, tableselection
+
+1. Focus the editor.
+1. Select the first row in a table.
+1. Press `backspace` key.
+1. Repeat 1-3 with `delete` key.
+1. Repeat 1-3 with `a`, `k` keys (random key validation).
+
+## Expected
+
+Selected row didn't change.
+
+## Unexpected
+
+Selected row has been deleted.

tests/plugins/tableselection/tableselection.js

@@ -172,6 +172,30 @@
 
 				assert.areSame( ranges, editor.getSelection().getRanges(), 'Selected ranges should be unchanged' );
 			} );
+		},
+
+		// (#1489)
+		'test random keys are not removing readonly selection': function( editor ) {
+			var selection = editor.getSelection(),
+				editable = editor.editable(),
+				table = CKEDITOR.document.getById( 'simpleTable' ).getHtml();
+
+			editor.setReadOnly( true );
+
+			bender.tools.setHtmlWithSelection( editor, table );
+
+			var row = editor.editable().findOne( 'tr' );
+			selection.selectElement( row );
+
+			editable.fire( 'keydown', new CKEDITOR.dom.event( { keyCode: 8 } ) ); // backspace
+			editable.fire( 'keydown', new CKEDITOR.dom.event( { keyCode: 46 } ) ); // delete
+
+			editable.fire( 'keypress', new CKEDITOR.dom.event( { keyCode: 65, charCode: 65 } ) ); // `a`
+			editable.fire( 'keypress', new CKEDITOR.dom.event( { keyCode: 93, charCode: 93 } ) ); // `t`
+
+			editor.setReadOnly( false );
+
+			assert.areSame( bender.tools.compatHtml( table ), editor.getData(), 'Editor data' );
 		}
 	};