Upload for Easy Image #1515
Merged
Upload for Easy Image #1515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ept with some logs and ugly commented code.
…et upload feature.
…e plugin.It's going to be extracted later. This type will be passed into Upload Widget Feature. The Idea is to have the ability to implement a different progress indicators for other widgets.
…ion of progress indicator with Easy Image itself.
…get upload feature. Extracted custom progress indicators types and styles into a common files.
Also removed good old conole logs.
… filled in 100% instead of being empty.
…g CIRCLE_THICKNESS const. Also removed stray CSS code.
There were also a couple minor code style corrections.
…y. Adjusted API docs.
This is done as a temp workaround, as the objects that we're passing as definition to features, are copies of the original definition. In other words any modifications to definition done at runtime (by other features setUps or at a widget runtime) are not available in setUp function. Because of that definition.name was not available (because it's assigned by the widget system at a widget construction time).
…ure by dropping onto readonly editor.
…ture and added docs for missing events.
…h is in the middle of loading into another editor. Reason why the issue exists is that loaders are bound per editor, and the ids can duplicate. For now I'll just patch this case in a way that it does not explode - however it requires a far more sophisticated fix.
…the widget is removed.
…s upon widget initialization. Previously easy image had a custom implementation for that, where it would handle dispatching widget upload. Since I had to implement it in upload feature core (to support cutting/copying the widget or drag and drop integration) it make sense to reuse what is already in the core.
…ite passes faster.
…minor doc fixes. Docs: simplified reporter methods description and corrected uploadStarted event docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
New feature
This PR contains
What changes did you make?
See #1483 for more details.
This issue has been already R+ed there, this PR is just about merging it into Easy Image feature branch.