Caption feature #1175

Comandeer · 2017-11-16T17:48:19Z

What is the purpose of this pull request?

New feature for new feature

Does your PR contain necessary tests?

All patches which change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.

This PR contains

Unit tests
Manual tests

What changes did you make?

I've added caption feature, which is responsible for toggling visibility of empty caption and for showing placeholder text.

mlewand

Tests

There are some failing tests (same for rebased branch and t/932-2992_old ba5d595).

All browsers

http://tests.ckeditor.test:1030/tests/plugins/easyimage/uploadwidget (test classic with easyimage (integration test) for each editor type)

Edge

IE11

Also 4 tests are failing on IE11 in the http://tests.ckeditor.test:1030/tests/plugins/imagebase/features/caption.

General Feedback

First of all: I'm pleased to see how well the existing widget feature concept worked for this case.

Back to the solution: well the concept is good, in a way that in general it works for the end user as expected.

But I'm not happy with approach of 'selectionChange' listener based solution. This event fires very, very often, on top of that you're iterating over each widget instance where you use getFocusedWidget().

Instead I would prefer to make as little footprint of this feature as possible.

The first issue you've been dealing with is that when focusing nested editable, the widget itself does not say it's focused. That's why you're iterating over every widget, and using widgetRepository.getByElement().

Instead I think much easier solution would be to mark the active (unrolled) caption area with an attribute, say data-cke-caption-active, and put it either on caption or a widget wrapper. As you move to another caption and call addPlaceholder() (or alike) this function could do a check in editor.editable() for a widget with data-cke-caption-active and hide the caption in that widget. It should also check if, by any chance, it's the same widget, in which case... the placeholder is already visible, and there's no reason to hide it (it would cause a redundant reflow).

With the above you would do a single widgetRepo.getByElement() check every selectionChange which seems to be a better trade.

Other

If getData() is called while the figure caption placeholder is shown, it will include placeholder text in returned value. I have added an unit test for that in ed24161.

In case you'd need some clarifications regarding this feedback - please let me know.

mlewand · 2017-12-28T16:26:03Z

plugins/imagebase/plugin.js

 	var featuresDefinitions = {
+		caption: {


We're going to have quite a few helper functions in a minute over here. Now we gained createCaption, isEmptyOrHasPlaceholder, addPlaceholder. I'd like to have it contained within a separate closure, simply sth like getCaptionFeature.

mlewand · 2017-12-28T16:38:12Z

plugins/imagebase/plugin.js

+			 * @member CKEDITOR.plugins.imagebase.featuresDefinitions.caption
+			 * @param {CKEDITOR.dom.element} sender Element, which triggered `selectionChange` event
+			 */
+			_toggleCaption: function( sender ) {


_toggleCaption is not a good function in this case, it works pretty much like a refresh function. "Toggle" implies that the state is going to be changed which is not the case.

mlewand · 2017-12-28T21:22:50Z

plugins/imagebase/plugin.js

+						i;
+
+					for ( i in widgets ) {
+						if ( widgets[ i ].features &&


widgets[ i ].features && CKEDITOR.tools.array.indexOf( widgets[ i ].features, 'caption' ) should get extracted to a function like widgetHasFeature() as it's also used here:

function isLinkable( widget ) { return widget && widget.features && CKEDITOR.tools.array.indexOf( widget.features, 'link' ) !== -1; }

mlewand · 2017-12-28T21:38:26Z

plugins/imagebase/plugin.js

+	function createCaption( widget ) {
+		var element = widget.element,
+			caption = element.getDocument().createElement( 'figcaption' ),
+			definition = widget.editor.widgets.registered[ widget.name ];


Widget instance has a definition property directly in it.

mlewand · 2017-12-28T21:40:10Z

plugins/imagebase/plugin.js

@@ -44,7 +66,84 @@
 		return CKEDITOR.plugins.link.parseLinkAttributes( widget.editor, widget.parts.link );
 	}

+	function createCaption( widget ) {
+		var element = widget.element,


We should integrate it with ACF. I think that in case 'figcaption' is not allowed we should simply not create caption part. In turn caption widget feature should not break anything (while ofc not adding any functionality).

mlewand · 2017-12-28T21:52:41Z

plugins/imagebase/plugin.js

+
+	function isEmptyOrHasPlaceholder( widget ) {
+
+		return !widget.editables.caption.getData() || widget.parts.caption.hasAttribute( 'data-cke-placeholder' );


dom.element has a data method that will simplify it for you.

mlewand · 2017-12-28T22:17:02Z

plugins/imagebase/plugin.js

+					editable = this.editables.caption;
+
+				if ( isFocused ) {
+					caption.removeAttribute( 'data-cke-hidden' );


This attribute should be removed after the placeholder was changed. This would mean less reflows which is always a good thing 👍

Comandeer · 2018-01-01T14:54:21Z

I'm still investigating failing tests in IE and Edge. Something fishy's going there as manual test for the same case is working just fine (probably artificial selection change is not working).

I also don't know how to deal with getData issue. I was trying to extend filter in editor.dataProcessor, but it seems that fetched data does not have all needed attributes (no data-cke-* ones), so I can't really filter out placeholder. Asserting its content is risky as user could have caption "Enter image caption". The only idea I have is to move placeholder content into CSS generated content.

Comandeer · 2018-01-01T23:21:06Z

I've pushed t/932-2992-css with working approach with placeholder inserted via CSS generated content. It fixed also issue with failing test in uploadwidget suite.

Tests in IE and Edge are still failing. it seems that these browsers don't fire _refreshCaption after inserting content into caption programatically. I didn't find a viable solution yet.

Comandeer · 2018-01-05T11:22:19Z

I've pushed improvement for tests both on t/932-2992 and t/932-2992-css. Now tests pass on Edge. One test is still failing on IE: test toggling captions (two widgets with empty captions) (classic) – but only if it's run with other tests and when console is closed.

mlewand

I see one more issue:

Provide detailed reproduction steps (if any)

Open Easy Image sample.
Select whole "Saturn V carrying Apollo 11" caption and remove it.
Put the selection outside of the widget.

Expected result

Caption should be hidden, as it is with newly inserted Easy Image widgets.

Actual result

Caption remains visible.

Other details

Browser: Any
OS: Any

Please provide unit tests for that case.

Comandeer · 2018-01-11T13:15:26Z

I've pushed fix to both of branches.

mlewand · 2018-01-11T16:52:37Z

I have a feeling that this is an edge case, but I'll put it here for my future reference, so that it can be extracted to a separate issue.

Provide detailed reproduction steps (if any)

Open Easy Image sample.
Make sure it's an updated version, where CKEditor old logo is displayed under the header.
Move your mouse over the widget and out of it.

Expected result

Widget wrapper gets highlighted with yellow outline.

Actual result

Widget wrapper is highlighted, but weird reflows are taking place.

CKEditor Easy Image Sample - Google Chrome 1_11_2018 5_48_23 PM.zip

Other details

Browser: Chrome
OS: Windows 10

HIDPI scaling: 250%

I wasn't able to repro it on other browsers, but I think to very specific layouting in this case (the cause for it might be that widget drag handler is affecting DOM - scroll bar appears, the width changes and reflow occurs.

mlewand

Generally CSS approach is the best idea here, so please merge this branch to t/932-2992 and continue with it.

I have found 2 issues (+1 kinda upstreamish, I'm talking aboud drag and drop one).

There are also some problems in unit tests, which is likely the cause for unit tests to fail in IE11.

mlewand · 2018-01-12T15:24:19Z

plugins/imagebase/plugin.js

+			widget.editables.caption.setData( '' );
+		}
+
+		function toggleVisibility( caption, isVisible ) {


toggleVisibility is not a good name, it implies that it will toggle visibility based on current state - however you require providing the visibility explicitly. So it should be setVisibility instead.

It seems that you don't like word "toggle". Every time you demand to change it to something else :D

Hehe, I like toggle methods, but only when it actually toggles something 😉

mlewand · 2018-01-13T18:40:02Z

plugins/imagebase/plugin.js

+		}
+
+		function toggleVisibility( caption, isVisible ) {
+			caption.data( 'cke-active', isVisible );


Your data attributes should feature caption in its name, otherwise you don't know what the attribute is related to.

So I suggest:

data-cke-caption-active

data-cke-caption-hidden

I've also renamed data-cke-placeholder to data-cke-caption-placeholder for consistency.

mlewand · 2018-01-13T18:45:07Z

tests/plugins/imagebase/features/manual/caption.md

@@ -0,0 +1,11 @@
+@bender-tags: 4.8.0, feature, 932


Please, correct the target to 4.9.0 version.

mlewand · 2018-01-13T18:46:51Z

tests/plugins/imagebase/features/manual/caption.html

@@ -0,0 +1,34 @@
+<div id="classic">
+	<p>Widget with caption:</p>


This is actually a widget without a caption.

mlewand · 2018-01-13T23:36:31Z

plugins/easyimage/plugin.js

@@ -198,6 +198,8 @@
 			widgetDefinition = CKEDITOR.plugins.imagebase.addFeature( editor, 'link', widgetDefinition );


I have noticed there's also a problem with drag and drop. But it should be fixed by TP#3351. Here are the steps:

Focus a Easy Image widget with no caption text (so that it has a placeholder text).

Drag and drop the widget into another position.

Expected

Caption box is visible with an empty caption placeholder text.

Actual

Caption is hidden.

After I rebased it onto latest t/932-2961 branch - that brought Balloon Panel, and it has an issue:

Balloon positioning

Focus Easy Image widget editor.

Put a collapsed selection inside of the caption.

Move focus back to widget (by clicking anywhere on the image).

Expected

Balloon panel shows, again in the same position.

Actual

Balloon panel points to the bottom edge of an image, overlapping the caption.

I have fixed this issue in #1448.

There's other issue related to blurring:

Focus a EI widget with no caption, so that placeholder text appears.

Put the focus outside of the editor.

Expected

Caption is removed/hidden.

Actual

Caption + placeholder remains visible.

Added manual test for that in tests\plugins\imagebase\features\manual\captionblur.md test.

mlewand · 2018-01-14T15:00:43Z

tests/plugins/imagebase/features/caption.js

+		};
+	}
+
+	function createMultipleToggleTest( options ) {


Please, add at least minimal comment to what the function does/what is its purpose. Currently one has to read its source code to understand this.

Please, review this assertion. It's a cause for 'test toggling captions (two widgets with empty captions)' to fail on IE11.

@mlewand which assertion exactly are you thinking of?

Actually I was referring to createMultipleToggleTest helper, sorry for the confusion.

mlewand · 2018-01-14T15:03:25Z

tests/plugins/imagebase/features/caption.js

+			}
+
+			bot.setData( getFixture( options.fixture ), function() {
+				var widgets = getWidgets( editor, options.widgetsCount );


Wouldn't it be a better idea to use widely available API? just go with editor.widgets.instances.slice() instead of adding new redundant code.

mlewand · 2018-01-14T15:11:42Z

tests/plugins/imagebase/features/caption.js

+			}
+
+			function assertOnFocus( widgets, expected ) {
+				forEach( widgets, function( widget, i ) {


In reality this code will never execute assertions for more than 1 widget. In YUI wait throws an exception, so the flow is never resumed afterwards.

mlewand · 2018-01-14T15:28:48Z

tests/plugins/imagebase/features/manual/caption.html

@@ -0,0 +1,34 @@
+<div id="classic">


Please, add inline editors. You have added floatingspace plugin in .md file but you did not use it with any editor.

mlewand · 2018-01-15T16:38:37Z

@Mgsy can I ask you for help with testing this feature?

Mgsy · 2018-01-16T08:31:48Z

Steps to reproduce

Select the image without the caption.
Apply Bold.
Focus the caption.

Current result

Placeholder doesn't disappear.

Expected result

Placeholder disappears.

Other information

OS: Windows 10, MacOS X
Browser: All browsers

Mgsy · 2018-01-16T09:09:28Z

Steps to reproduce

Focus the image.
Copy it.
Put the caret inside image caption.
Paste.

Current result

Image has been pasted, but editor has crashed.

Expected result

Image is pasted without errors.

Error

plugin.js:2858 Uncaught TypeError: Cannot read property 'editables' of undefined
    at plugin.js:2858
    at CKEDITOR.htmlParser.element.forEach (fragment.js:622)
    at CKEDITOR.htmlParser.element.forEach (fragment.js:636)
    at CKEDITOR.htmlParser.element.forEach (fragment.js:636)
    at CKEDITOR.htmlParser.element.forEach (fragment.js:636)
    at Editor.<anonymous> (plugin.js:2813)
    at Editor.listenerFirer (event.js:144)
    at Editor.CKEDITOR.event.fire (event.js:290)
    at Editor.CKEDITOR.editor.fire (editor_basic.js:24)
    at CKEDITOR.htmlDataProcessor.toDataFormat (htmldataprocessor.js:294)

Other information

OS: Windows 10, MacOS X
Browser: All browsers

Mgsy · 2018-01-16T09:23:59Z

Steps to reproduce

Focus the empty image caption.
Apply Bold.

Current result

Caption disappears and selection moves to the previous block.

Expected result

Selection stays inside the caption and bold activates.

Other information

OS: Windows 10, MacOS X
Browser: Firefox, Edge

Mgsy · 2018-01-16T10:35:36Z

Steps to reproduce

Focus the empty caption.
Type test.
Undo.

Current result

Caption disappears.

Expected result

Caption is visible and selection stays inside the empty caption.

Other information

OS: Windows 10, MacOS X
Browser: All browsers

Mgsy · 2018-01-16T10:51:03Z

Steps to reproduce

Open the sample with 2 images with captions.
Focus first image's caption.
Press Tab.
Select caption of second image with Ctrl + A.
Press Delete.
Press Shift + Tab.

Current result

Second image's empty caption is visible.

Expected result

Second image's empty caption hides.

Other information

OS: Windows 10, MacOS X
Browser: All browsers

Comandeer · 2018-01-22T08:26:48Z

I've extracted issues raised by @Mgsy as separate subtasks. Additionally I've reported #1469.

mlewand · 2018-01-25T13:20:30Z

Open http://tests.ckeditor.test:1030/tests/plugins/imagebase/features/manual/caption
Focus the first captionless EI widget.
Cut it (ctrl/cmd+x).
Paste it.

Expected result

Widget is focused, caption placeholder is visible.

Actual result

Widget is focused but there's no caption placeholder visible.

Other details

Browser: Chrome, Edge, Firefox
OS: Windows 10

mlewand

I have found mainly a polishing tasks, we need to make it production ready.

Also please add proper namespace for catpion feature - just mark it as a private member. I have proposed syntax for that in #1483, see docs for getUploadFeature in plugins/imagebase/plugin.js file.

mlewand · 2018-01-25T12:16:55Z

tests/plugins/imagebase/features/caption.js

+	 * during each step. Assertions are made for every widget in the group.
+	 *
+	 * @param {Object} options
+	 * @param {String} options.fixture Fixture's name.


It's an id I think you meant it, but someone might get it wrong when it's referred as name.

mlewand · 2018-01-25T12:19:29Z

tests/plugins/imagebase/features/caption.js

+	 * during each step.
+	 *
+	 * @param {Object} options
+	 * @param {String} options.fixture Fixture's name.


It' an id I think you meant it, but someone might get it wrong when it's referred as name.

mlewand · 2018-01-25T12:20:35Z

tests/plugins/imagebase/features/caption.js

+	 * @param {Boolean} options.initial Caption visibility at the start of the test.
+	 * @param {Boolean} options.focus Caption visibility after calling focus function.
+	 * @param {Boolean} options.blur Caption visibility after calling blur function.
+	 * @param {Boolean} options.onInit Callback to run at the beginning of the test.


This is a function. Also this is an optional parameter.

mlewand · 2018-01-25T12:21:26Z

tests/plugins/imagebase/features/caption.js

+	 * @param {Function} options.onFocus Callback to run after focus function.
+	 * @param {Function} options.onBlur Callback to run after blur function.
+	 * @param {Function} options.customFocus Function to be called instead of default focus function.
+	 * @param {Function} options.customBlur Function to be called instead of default blur function.


onFocus onBlur customFocus and customBlur are all optional.

mlewand · 2018-01-25T12:26:43Z

plugins/imagebase/plugin.js

+				function listener( evt ) {
+					var path = evt.name === 'blur' ? editor.elementPath() : evt.data.path,
+						sender = path ? path.lastElement : null,
+						widgets = editor.widgets,


widgets is used only in previous. I think it could be inlined there. It will get lengthy (115 chars) but it will still be under 120 👌

I don't see any 115 chars line, there is only 135 chars one, but it's not the previous one 🤔

I'm sorry, wasn't accurate. What I meant is that widgets variable is used only in line previous = widgets.getByElement( editor.editable(…) then the rest is applicable.

mlewand · 2018-01-25T12:32:41Z

plugins/imagebase/lang/en.js

@@ -3,5 +3,5 @@ Copyright (c) 2003-2017, CKSource - Frederico Knabben. All rights reserved.
 For licensing, see LICENSE.md or http://ckeditor.com/license
 */
 CKEDITOR.plugins.setLang( 'imagebase', 'en', {
-	captionPlaceholder: 'Caption'
+	captionPlaceholder: 'Enter image caption'


There's no meta lang entry for this label.

mlewand · 2018-01-25T13:01:14Z

plugins/imagebase/plugin.js

+			},
+
+			/**
+			 * Method used inside {@link CKEDITOR.editor#event-selectionChange} event to decide if caption for given widget


You have tied this method strongly with the selectionChange and now it uses also blur. It's possible there will be different events soon. Please make the docs event-agnostic.

mlewand · 2018-01-25T13:12:28Z

tests/plugins/easyimage/manual/balloontoolbar/caption.md

+
+---
+
+Repeat above steps for all other editors.


Please, mention that Edge users could be affected by #1458 - and experience focus quirks when focusing between the editors.

mlewand · 2018-01-25T13:22:50Z

tests/plugins/imagebase/features/manual/caption.html

@@ -0,0 +1,92 @@
+<h2>Classic editor</h2>


Now that we have inline editors, please import CSS files, so that the widgets in inline editors are styled properly.

Actually there aren't any styles that could be additionally loaded – all are already loaded. It looks differently than EI because it's a custom, test image widget:

plugin.addImageWidget( editor, 'testWidget', plugin.addFeature( editor, 'caption', {} ) );

I mean, it's a figure - I wanted figures to be styled consistently in all editors. It just requires importing contents.css - see 289bd70.

mlewand · 2018-01-25T13:30:45Z

tests/plugins/imagebase/features/caption.js

@@ -0,0 +1,455 @@
+/* bender-tags: editor,widget */


Please ignore this test in unspported environments.

Comandeer · 2018-01-29T16:54:11Z

I've fixed all raised issues, I've also rebased to the newest t/932-2961.

…ification plugins.

mlewand

LGTM, I just added subtle corrections to manual tests.

There are still some bugs related to captions, but they're not big enough to stop this feature. Instead bugs will be extracted to a followup issues.

Caption feature

Comandeer force-pushed the t/932-2961 branch from 1e1fd73 to bf97a5c Compare December 5, 2017 08:30

Comandeer force-pushed the t/932-2992 branch from ce58a3a to ba5d595 Compare December 5, 2017 08:34

Comandeer force-pushed the t/932-2961 branch from 704aec8 to fbbd35d Compare December 27, 2017 13:18

mlewand self-requested a review December 28, 2017 11:52

mlewand force-pushed the t/932-2992 branch 2 times, most recently from b314b68 to ec49660 Compare December 28, 2017 16:06

mlewand suggested changes Dec 28, 2017

View reviewed changes

Comandeer requested a review from mlewand January 5, 2018 11:22

mlewand suggested changes Jan 11, 2018

View reviewed changes

mlewand force-pushed the t/932-2992 branch from b33a542 to 0420009 Compare January 11, 2018 16:35

mlewand self-requested a review January 12, 2018 15:23

mlewand suggested changes Jan 14, 2018

View reviewed changes

mlewand mentioned this pull request Jan 14, 2018

Corrections to Easy Image caption pull request #1448

Merged

2 tasks

Comandeer force-pushed the t/932-2992 branch from 3378e68 to e883ee6 Compare January 15, 2018 16:22

Comandeer requested a review from mlewand January 22, 2018 08:26

Comandeer force-pushed the t/932-2992 branch from e883ee6 to 375a018 Compare January 22, 2018 09:02

mlewand suggested changes Jan 25, 2018

View reviewed changes

Comandeer added 17 commits January 29, 2018 16:59

Fix incorrect placeholder behavior on editor's blur.

31c98c8

Update manual test.

d8f24c6

Remove redundant getWidgets function.

fb61b15

Add check for path existence.

6a34d83

Update assertion for blurring editor when focus is in caption unit test.

ea54f2f

Add API docs for tests.

c811285

Fix tests for multiple widgets.

a8c3349

Rename toggleVisibility to setVisibility.

ed7f6de

Rename data attributes.

28c4554

Move placeholder color definition to pseudoelement block.

55a46f2

Add language meta entry for caption placeholder.

76b545b

Update API docs.

4f6be6c

Inline widgets variable.

69dd9a9

Update unit test API docs.

c8c3421

Ingore unit tests in old IEs.

82d8f0a

Add note for Edge users.

2fb919d

Add manual test for disabled caption.

d161e8a

Comandeer force-pushed the t/932-2992 branch from 375a018 to d161e8a Compare January 29, 2018 16:52

Comandeer requested a review from mlewand January 29, 2018 16:54

mlewand added 4 commits January 30, 2018 11:27

Corrected doc typo.

c595592

Added consistent content CSS to the caption test.

289bd70

Corrected code style.

f141108

Tests: Simplified manual test checks, and removed one of 2 source ver…

227e525

…ification plugins.

mlewand approved these changes Jan 30, 2018

View reviewed changes

mlewand merged commit 0d66124 into t/932-2961 Jan 30, 2018

mlewand deleted the t/932-2992 branch January 30, 2018 11:59

Mgsy mentioned this pull request Jan 31, 2018

Empty caption doesn't hide after moving focus to another caption with Shift + Tab #1543

Open

mlewand added a commit that referenced this pull request Feb 5, 2018

Merge pull request #1175 from ckeditor/t/932-2992

ecde1d3

Caption feature

Comandeer pushed a commit that referenced this pull request Feb 6, 2018

Merge pull request #1175 from ckeditor/t/932-2992

35834b9

Caption feature


		function isEmptyOrHasPlaceholder( widget ) {

		return !widget.editables.caption.getData() \|\| widget.parts.caption.hasAttribute( 'data-cke-placeholder' );

		@@ -0,0 +1,34 @@
		<div id="classic">
		<p>Widget with caption:</p>

		@@ -198,6 +198,8 @@
		widgetDefinition = CKEDITOR.plugins.imagebase.addFeature( editor, 'link', widgetDefinition );

Caption feature #1175

Caption feature #1175

Conversation

Comandeer commented Nov 16, 2017

What is the purpose of this pull request?

Does your PR contain necessary tests?

This PR contains

What changes did you make?

mlewand left a comment • edited Loading

Choose a reason for hiding this comment

Tests

All browsers

Edge

IE11

General Feedback

More Performance-friendly Solution

Other

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Comandeer commented Jan 1, 2018

Comandeer commented Jan 1, 2018

Comandeer commented Jan 5, 2018

mlewand left a comment • edited Loading

Choose a reason for hiding this comment

Provide detailed reproduction steps (if any)

Expected result

Actual result

Other details

Comandeer commented Jan 11, 2018

mlewand commented Jan 11, 2018 • edited Loading

Provide detailed reproduction steps (if any)

Expected result

Actual result

Other details

mlewand left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Expected

Actual

mlewand Jan 14, 2018 • edited Loading

Choose a reason for hiding this comment

Balloon positioning

Expected

Actual

Choose a reason for hiding this comment

Expected

Actual

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mlewand Jan 15, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mlewand commented Jan 15, 2018

Mgsy commented Jan 16, 2018 • edited by mlewand Loading

Steps to reproduce

Current result

Expected result

Other information

Mgsy commented Jan 16, 2018

Steps to reproduce

Current result

Expected result

Error

Other information

Mgsy commented Jan 16, 2018

mlewand left a comment •

edited

Loading

mlewand left a comment •

edited

Loading

mlewand commented Jan 11, 2018 •

edited

Loading

mlewand left a comment •

edited

Loading

mlewand Jan 14, 2018 •

edited

Loading

mlewand Jan 15, 2018 •

edited

Loading

Mgsy commented Jan 16, 2018 •

edited by mlewand

Loading

mlewand Jan 25, 2018 •

edited

Loading