-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration flag forceSimpleAmpersand does not work #965
Comments
Run ampersand replacement after the htmlEncodeAttr, otherwise the results are overwritten (ckeditor#965)
The sad facts are some websites do not support the & amp; and expect only the & to be there. thus as is -- CKeditor breaks the URL. Who gives a damn about the specs -- CKEditor needs to fix this and let the users control what is needed and not force something that doesn't work (sometimes) |
Looks like this problem was introduced with 4.5.0 - with 4.4.8 it works as expected. |
@alexmaris your commit solves the problem (bug) for me. Cloud you make a pull request for this fix? |
Ahh yes I can, I think I was in the middle of writing a unit test for it but was pulled away. I'll submit a PR in a few. |
Run ampersand replacement after the htmlEncodeAttr, otherwise the results are overwritten (ckeditor#965)
PR submitted, sorry for the delay! |
Run ampersand replacement after the htmlEncodeAttr, otherwise the results are overwritten (#965)
I wrote this several years ago, and today 6/24/20 it is still an issue. forceSimpleAmpersand does not work. CKeditor people,,you are not Google. We the users of your product wear big pants and can deal with backward compatibility. Will you get this fixed and stop hiding behind some outdated standards. I just spent hours on this today. I have better things to do with my life. |
@mlandmann I see this issue was fixed some time ago in #2416 and #2418. However, if you still experiencing any problems with this configuration option please open a new issue describing your case and reproduction steps. |
Run ampersand replacement after the htmlEncodeAttr, otherwise the results are overwritten (ckeditor/ckeditor4#965)
Are you reporting a feature request or a bug?
Bug
Check if the issue is already reported
https://dev.ckeditor.com/ticket/16746#no1
Previously reported in this ticket, but the steps to replicate were not correct. The documentation states that the
forceSimpleAmpersand
flag will "force using&
instead of&
in element attributes values."(https://docs.ckeditor.com/#!/api/CKEDITOR.config-cfg-forceSimpleAmpersand)
Provide detailed reproduction steps (if any)
forceSimpleAmpersand
option set totrue
(https://codepen.io/anon/pen/gGmOmW?editors=1010)<a>
tag with anhref
attribute that contains an ampersand ex:<a href="http://www.blah.com?foo=1&bar=2">Test link</a>
Expected result
Anchor tag href property should remain the same:
<a href="http://www.blah.com?foo=1&bar=2">Test link</a>
Actual result
Anchor tag href property has the ampersand encoded
<a href="http://www.blah.com?foo=1&bar=2">Test link</a>
Other details
The text was updated successfully, but these errors were encountered: