Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when filter changes element node to text node #3593

Closed
msamsel opened this issue Oct 23, 2019 · 1 comment
Closed

Error when filter changes element node to text node #3593

msamsel opened this issue Oct 23, 2019 · 1 comment
Assignees
@msamsel
Labels
core The issue is caused by the editor core code. status:confirmed An issue confirmed by the development team. type:bug A bug.
Milestone
4.13.1

Comments

@msamsel
Copy link
Contributor

msamsel commented Oct 23, 2019

Type of report

Bug

Provide detailed reproduction steps (if any)

ckeditor4/core/htmlparser/filter.js

Lines 221 to 223 in 5fa2a5b

return type == CKEDITOR.NODE_ELEMENT ? this.onElement( context, node ) :
type == CKEDITOR.NODE_TEXT ? new CKEDITOR.htmlParser.text( this.onText( context, node.value ) ) :
type == CKEDITOR.NODE_COMMENT ? new CKEDITOR.htmlParser.comment( this.onComment( context, node.value ) ) : null;

onText and onComment methods requires 3 arguments to work correctly, which are not passed to the method call

Expected result

There is no error when the filter changes the element node to the text node or the comment node.

Actual result

Error

Other details

  • Browser: All
  • OS: …
  • CKEditor version: …
  • Installed CKEditor plugins: …
@msamsel msamsel added type:bug A bug. status:confirmed An issue confirmed by the development team. core The issue is caused by the editor core code. labels Oct 23, 2019
msamsel pushed a commit that referenced this issue Oct 23, 2019
This fix should be made separately with #3593, wth proper tests.
b30f34b
@msamsel msamsel self-assigned this Oct 30, 2019
This was referenced Oct 30, 2019
Merged
Merged
msamsel pushed a commit that referenced this issue Nov 6, 2019
Revert "This fix should be made separately with #3593, wth proper tes…
4101a6f 
…ts."

This reverts commit b30f34b.
@Comandeer Comandeer added this to the 4.13.1 milestone Nov 12, 2019
@Comandeer
Copy link
Member

Merged into 4.13.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msamsel msamsel

Labels
core The issue is caused by the editor core code. status:confirmed An issue confirmed by the development team. type:bug A bug.
Projects
None yet
Milestone
4.13.1
Development

No branches or pull requests
2 participants
@Comandeer @msamsel