Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements for list commands when block elements are inside list items #2441

Open
msamsel opened this issue Sep 26, 2018 · 2 comments
Open
Labels
plugin:list The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:feature A feature request.

Comments

@msamsel
Copy link
Contributor

msamsel commented Sep 26, 2018

Type of report

Feature request

Provide description of the new feature

Use those markups in editor:

  1. Select entire content and change list type to numbered.
<ul>
	<li>
	<div>
	<div>foo</div>
	</div>
	</li>
	<li>bar</li>
</ul>

screen shot 2018-09-26 at 16 15 27

  1. Apply twice unordered list command (notice element's order swap after 2nd apply of unordered list);
<ul>
	<li>foo</li>
	<li>
	<div>
	<div>bar</div>
	</div>
	</li>
	<li>baz</li>
</ul>

List looks strange and this behaviour seems to be not expected by the user.
List plugin should better handle multiple nested block elements inside lists.

Situation was noticed during case #2411.

@msamsel msamsel added type:feature A feature request. status:confirmed An issue confirmed by the development team. plugin:list The plugin which probably causes the issue. labels Sep 26, 2018
@mlewand
Copy link
Contributor

mlewand commented Sep 28, 2018

@msamsel please provide more accurate steps.

Apply few times

You simply mean pressing (applying) unordered list twice, right?

In that case how did you end with markup from the second listing? I mean where did the "bar" block come from?

Also issue is simply a bug rather than feature request - what happens in the editor is unexpected output.

@msamsel
Copy link
Contributor Author

msamsel commented Sep 28, 2018

You simply mean pressing (applying) unordered list twice, right?

yes, I correct description to press unordered list twice.

In that case how did you end with markup from the second listing? I mean where did the "bar" block come from?

It's was some variation of markup which I test. It wasn't present in any source, but it's still valid html markup.

Also issue is simply a bug rather than feature request - what happens in the editor is unexpected output.

Should I separate 2nd case as a bug?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin:list The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:feature A feature request.
Projects
None yet
Development

No branches or pull requests

2 participants