Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pasting empty nested list and converting it to different list type throws error #2411

Closed
jswiderski opened this issue Sep 13, 2018 · 3 comments
Assignees
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:list The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. support An issue reported by a commercially licensed client. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Milestone

Comments

@jswiderski
Copy link
Contributor

jswiderski commented Sep 13, 2018

Type of report

Bug

Provide detailed reproduction steps (if any)

  1. Go to https://sdk.ckeditor.com/samples/fullpreset.html.
  2. Clear Editor contents and switch to source mode.
  3. Paste below HTML
<ul>	
	<li>
	<div>test
	<ul>
	</ul>
	</div>
	</li>
	<li>test</li>
</ul>

In Chrome it is enough to use

<ul>	
	<li>
	<div>test
	<ul>
	</ul>
	</div>
	</li>
</ul>
  1. Switch to wysiwyg mode
  2. Press Ctrl+A na dclick on Numbered List button

Expected result

No error gets thrown.

Perhaps as an alternative solution such list should be filtered by ACF.

Actual result

JavaScript error gets thrown:
Message: Cannot read property 'parent' of undefined
Line: 319
URI: /ckeditor-dev/plugins/list/plugin.js

Other details

  • Browser: Any
  • OS: Any
  • CKEditor version: 4.0+
  • Installed CKEditor plugins: List

The Original scenario was:

  1. Open https://codepen.io/pratikgolchha/pen/wxGbRd in Edge
  2. Copy everything form https://docs.microsoft.com/zh-cn/powerapps/maker/canvas-apps/controls/control-gallery and paste in the CKEditor
  3. Select all contents and apply bulleted list and then numbered list
  4. Check the console

This document is huge so maybe there is something extra what is causing the same issue (there shouldn't be but it may).

@jswiderski jswiderski added type:bug A bug. status:confirmed An issue confirmed by the development team. support An issue reported by a commercially licensed client. labels Sep 13, 2018
@mlewand mlewand added good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. target:minor Any docs related issue that can be merged into a master or major branch. plugin:list The plugin which probably causes the issue. labels Sep 13, 2018
@msamsel msamsel self-assigned this Sep 17, 2018
@jswiderski
Copy link
Contributor Author

This issue could be related: #2438

@msamsel
Copy link
Contributor

msamsel commented Sep 26, 2018

Additional markup to check:

<p><br></p><ul></ul><ul><li><a href="https://powerusers.microsoft.com/plugins/common/feature/oauth2sso/sso_login_redirect?referer=https%3A%2F%2Fpowerusers.microsoft.com%2Ft5%2FPowerApps-Community%2Fct-p%2FPowerApps1">Register</a></li><li><br></li><li>·</li><li><br></li><li><a href="https://powerusers.microsoft.com/plugins/common/feature/oauth2sso/sso_login_redirect?referer=https%3A%2F%2Fpowerusers.microsoft.com%2Ft5%2FPowerApps-Community%2Fct-p%2FPowerApps1">Sign In</a></li><li><br></li><li>·</li><li><br></li><li><a href="https://powerusers.microsoft.com/t5/help/faqpage">Help</a></li></ul><p><br></p>

@mlewand
Copy link
Contributor

mlewand commented Jan 3, 2019

Fixed with #2440.

@mlewand mlewand closed this as completed Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:list The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. support An issue reported by a commercially licensed client. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Projects
None yet
Development

No branches or pull requests

3 participants