Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autolink plugin doesn't work without link plugin #1824

Closed
jacekbogdanski opened this issue Mar 20, 2018 · 1 comment · Fixed by #2518
Closed

Autolink plugin doesn't work without link plugin #1824

jacekbogdanski opened this issue Mar 20, 2018 · 1 comment · Fixed by #2518
Assignees
@sculpt0r
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:autolink The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:bug A bug.
Milestone
Backlog

Comments

@jacekbogdanski
Copy link
Member

Are you reporting a feature request or a bug?

Bug

Provide detailed reproduction steps (if any)

  1. Open CKEditor sample with enabled autolink plugin and not included link plugin.
  2. Copy URL e.g. http://google.com.
  3. Paste URL into an editor.

Expected result

URL should be turned into link e.g. <a href="http://google.com">google.com</a>

Actual result

URL is pasted as a text.

Other details

autolink plugin should probably require link plugin by default.

  • Browser: Any
  • OS: Any
  • CKEditor version: 4.8.0
  • Installed CKEditor plugins: autolink
@jacekbogdanski jacekbogdanski added type:bug A bug. status:confirmed An issue confirmed by the development team. plugin:autolink The plugin which probably causes the issue. labels Mar 20, 2018
@mlewand mlewand added good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. target:minor Any docs related issue that can be merged into a master or major branch. labels Mar 20, 2018
@mlewand mlewand added this to the Backlog milestone Mar 20, 2018
@jacekbogdanski jacekbogdanski self-assigned this Oct 25, 2018
@jacekbogdanski jacekbogdanski mentioned this issue Oct 25, 2018
Merged
2 tasks
mlewand added a commit that referenced this issue Feb 18, 2019
@mlewand
Tests: added link plugin.
f0c5b5d 
That has to be added due to #1824.
mlewand added a commit that referenced this issue Feb 18, 2019
@mlewand
Tests: added link plugin.
ee1e3ec 
That has to be added due to #1824.
ad1992 pushed a commit to interviewstreet/ckeditor-dev that referenced this issue May 15, 2019
@mlewand @ad1992
Tests: added link plugin.
c1b929c 
That has to be added due to ckeditor#1824.
@f1ames f1ames removed the target:minor Any docs related issue that can be merged into a master or major branch. label Nov 12, 2019
@f1ames f1ames added the size:S label Dec 7, 2020
@sculpt0r sculpt0r self-assigned this Dec 8, 2020
@sculpt0r sculpt0r linked a pull request Dec 8, 2020 that will close this issue
Link is now required by autolink plugin #2518
Merged
2 tasks
@CKEditorBot
Copy link
Collaborator

Closed in #2518

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sculpt0r sculpt0r

Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:autolink The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:bug A bug.
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Link is now required by autolink plugin ckeditor/ckeditor4
5 participants
@f1ames @mlewand @sculpt0r @jacekbogdanski @CKEditorBot